On Macs, Ohana (mana) compilation fails unless kapa is disabled

[jester@…]

Since forever, compilation of mana fails on Macs with errors about multiple definitions of _DVOTableMode and _DVOTableFormat. Out of the box, there is a warning message about using -bind_at_load; I added that into the mana Makefile and re-made, but the error itself does not go away:

jester@panapple mana$ pwd
/Users/jester/IPP/ipp-2.2/Ohana/src/opihi/mana
jester@panapple mana$ make
gcc -g -O0 -o /Users/jester/IPP/ipp-2.2/Ohana/src/opihi/bin/mana.darwin_x86 /Users/jester/IPP/ipp-2.2/Ohana/src/opihi/mana/rawstars.darwin_x86.o /Users/jester/IPP/ipp-2.2/Ohana/src/opihi/mana/fitcontour.darwin_x86.o /Users/jester/IPP/ipp-2.2/Ohana/src/opihi/mana/starcontour.darwin_x86.o /Users/jester/IPP/ipp-2.2/Ohana/src/opihi/mana/version.darwin_x86.o /Users/jester/IPP/ipp-2.2/Ohana/src/opihi/mana/findpeaks.darwin_x86.o /Users/jester/IPP/ipp-2.2/Ohana/src/opihi/mana/init.darwin_x86.o /Users/jester/IPP/ipp-2.2/Ohana/src/opihi/mana/mana.darwin_x86.o /Users/jester/IPP/ipp-2.2/Ohana/src/opihi/mana/findrowpeaks.darwin_x86.o -lbasiccmd -ldatacmd -lastrocmd -lshell -ldata -ldvo -lkapa -lFITS -lohana -L/Users/jester/IPP/ipp-2.2/Ohana/src/opihi/lib -L/Users/jester/psconfig/ipp-2.2.darwin_x86/lib -L/Users/jester/psconfig/ipp-2.2.darwin_x86/lib -L/usr/lib -L/sw/lib -L/usr/X11R6/lib -L/usr/local/mysql/lib -lpng -lz -ljpeg -lreadline -lX11 -lpthread -lm -lncurses -lmysqlclient -bind_at_load
/usr/bin/ld: warning multiple definitions of symbol _DVOTableMode
/Users/jester/psconfig/ipp-2.2.darwin_x86/lib/libkapa.dylib(single module) definition of _DVOTableMode
/Users/jester/psconfig/ipp-2.2.darwin_x86/lib/libdvo.dylib(single module) definition of _DVOTableMode
/usr/bin/ld: warning multiple definitions of symbol _DVOTableFormat
/Users/jester/psconfig/ipp-2.2.darwin_x86/lib/libkapa.dylib(single module) definition of _DVOTableFormat
/Users/jester/psconfig/ipp-2.2.darwin_x86/lib/libdvo.dylib(single module) definition of _DVOTableFormat
/usr/bin/ld: multiple definitions of symbol _str_to_time
/Users/jester/psconfig/ipp-2.2.darwin_x86/lib/libohana.dylib(single module) definition of _str_to_time
/usr/local/mysql/lib/libmysqlclient.a(my_time.o) definition of _str_to_time in section (TEXT,text)
collect2: ld returned 1 exit status
make: * Users/jester/IPP/ipp-2.2/Ohana/src/opihi/bin/mana.darwin_x86 Error 1

On Linux, the compilation of mana looks like this:

jester@aida77 mana$ pwd
/disk1/jester/IPP/ipp-2.2/Ohana/src/opihi/mana
jester@aida77 mana$ make
gcc -g -O0 -o /disk1/jester/IPP/ipp-2.2/Ohana/src/opihi/bin/mana.lin64 /disk1/jester/IPP/ipp-2.2/Ohana/src/opihi/mana/rawstars.lin64.o /disk1/jester/IPP/ipp-2.2/Ohana/src/opihi/mana/fitcontour.lin64.o /disk1/jester/IPP/ipp-2.2/Ohana/src/opihi/mana/starcontour.lin64.o /disk1/jester/IPP/ipp-2.2/Ohana/src/opihi/mana/version.lin64.o /disk1/jester/IPP/ipp-2.2/Ohana/src/opihi/mana/findpeaks.lin64.o /disk1/jester/IPP/ipp-2.2/Ohana/src/opihi/mana/init.lin64.o /disk1/jester/IPP/ipp-2.2/Ohana/src/opihi/mana/mana.lin64.o /disk1/jester/IPP/ipp-2.2/Ohana/src/opihi/mana/findrowpeaks.lin64.o -lbasiccmd -ldatacmd -lastrocmd -lshell -ldata -ldvo -lkapa -lFITS -lohana -L/disk1/jester/IPP/ipp-2.2/Ohana/src/opihi/lib -L/disk1/jester/IPP/ipp-2.2.lin64/lib -L/usr/lib64 -L/disk1/jester/IPPipp-2.2.lin64/lib -lpng -lz -ljpeg -lreadline -lX11 -lpthread -lm -lncurses -lmysqlclient
compiled mana

The workaround has been to disable use of kapa everywhere, but since Josh called for compile failures, here you go!

[eugene]

update to dvo.h which fixes the enum conflicts on macs

[eugene]

I believe Michael Wood-Vasey has tracked this one down: it was due to a poorly defined set of enums in dvo.h.

I am attaching an update to dvo.h which should address this issue (place in Ohana/src/libdvo/include replacing the existing dvo.h)

[jester@…]

Thanks... except now I get a different error - maybe you've changed other things in dvo.h, too? It complains about too many arguments to SkyListFree.

gcc -g -O0 -fPIC -DHAVE_MYSQL_H -I/Users/jester/IPP/ipp-2.2/Ohana/src/libdvo/include -I/Users/jester/psconfig/ipp-2.2.darwin_x86/include -I/usr/include -I/usr/local/include -I/sw/include -I/usr/local/mysql/include -Ddarwin_x86 -c /Users/jester/IPP/ipp-2.2/Ohana/src/libdvo/src/skyregion_ops.c -o /Users/jester/IPP/ipp-2.2/Ohana/src/libdvo/src/skyregion_ops.darwin_x86.o
/Users/jester/IPP/ipp-2.2/Ohana/src/libdvo/src/skyregion_ops.c: In function 'SkyListByBounds':
/Users/jester/IPP/ipp-2.2/Ohana/src/libdvo/src/skyregion_ops.c:234: error: too many arguments to function 'SkyListFree'
/Users/jester/IPP/ipp-2.2/Ohana/src/libdvo/src/skyregion_ops.c: In function 'SkyListChildrenByBounds':
/Users/jester/IPP/ipp-2.2/Ohana/src/libdvo/src/skyregion_ops.c:291: error: too many arguments to function 'SkyListFree'
/Users/jester/IPP/ipp-2.2/Ohana/src/libdvo/src/skyregion_ops.c: At top level:
/Users/jester/IPP/ipp-2.2/Ohana/src/libdvo/src/skyregion_ops.c:334: error: conflicting types for 'SkyListFree'
/Users/jester/IPP/ipp-2.2/Ohana/src/libdvo/include/dvo.h:431: error: previous declaration of 'SkyListFree' was here
make[3]: * Users/jester/IPP/ipp-2.2/Ohana/src/libdvo/src/skyregion_ops.darwin_x86.o Error 1
make[2]: * [libdvo.install] Error 2
make[1]: * [libs] Error 2
make: * [all] Error 2
problem building Ohana : failure in make

[eugene]

replacement for previous dvo.h (good for ipp-2.2.0)

[eugene]

oops: I've included just the diff wrt the ipp-2.2.0 version of this file (i had made some api changes since that release)

try again, please!

[jester@…]

That's better... it now fails with the duplicate _str_to_time definition:

gcc -g -O0 -o /Users/jester/IPP/ipp-2.2/Ohana/src/opihi/bin/mana.darwin_x86 /Users/jester/IPP/ipp-2.2/Ohana/src/opihi/mana/rawstars.darwin_x86.o /Users/jester/IPP/ipp-2.2/Ohana/src/opihi/mana/fitcontour.darwin_x86.o /Users/jester/IPP/ipp-2.2/Ohana/src/opihi/mana/starcontour.darwin_x86.o /Users/jester/IPP/ipp-2.2/Ohana/src/opihi/mana/version.darwin_x86.o /Users/jester/IPP/ipp-2.2/Ohana/src/opihi/mana/findpeaks.darwin_x86.o /Users/jester/IPP/ipp-2.2/Ohana/src/opihi/mana/init.darwin_x86.o /Users/jester/IPP/ipp-2.2/Ohana/src/opihi/mana/mana.darwin_x86.o /Users/jester/IPP/ipp-2.2/Ohana/src/opihi/mana/findrowpeaks.darwin_x86.o -lbasiccmd -ldatacmd -lastrocmd -lshell -ldata -ldvo -lkapa -lFITS -lohana -L/Users/jester/IPP/ipp-2.2/Ohana/src/opihi/lib -L/Users/jester/psconfig/ipp-2.2.darwin_x86/lib -L/Users/jester/psconfig/ipp-2.2.darwin_x86/lib -L/usr/lib -L/sw/lib -L/usr/X11R6/lib -L/usr/local/mysql/lib -lpng -lz -ljpeg -lreadline -lX11 -lpthread -lm -lncurses -lmysqlclient -bind_at_load
/usr/bin/ld: multiple definitions of symbol _str_to_time
/Users/jester/psconfig/ipp-2.2.darwin_x86/lib/libohana.dylib(single module) definition of _str_to_time
/usr/local/mysql/lib/libmysqlclient.a(my_time.o) definition of _str_to_time in section (TEXT,text)
collect2: ld returned 1 exit status
make[4]: * Users/jester/IPP/ipp-2.2/Ohana/src/opihi/bin/mana.darwin_x86 Error 1
make[3]: * [mana] Error 2
make[2]: * [all] Error 2
make[1]: * [opihi] Error 2
make: * [all] Error 2
problem building Ohana : failure in make

I know Nicolas Ohana-namespaced your str_to_time, I guess it's going to be in the next release. (Wonder why this conflict only appears on Macs)

[eugene]

added the ohana_ namespace to the str_to_radec and related functions.