Opened 20 years ago
Closed 16 years ago
#776 closed defect (fixed)
pmConfig fails to detect invalid files
| Reported by: | Owned by: | Paul Price | |
|---|---|---|---|
| Priority: | low | Milestone: | |
| Component: | psModules | Version: | 0.10.0 |
| Severity: | normal | Keywords: | |
| Cc: |
Description (last modified by )
(release v12_0) The code in pmConfig fails to check the error codes from loadRecipes (and
in fact errors from below are not propagated even as far as loadRecipes).
I have checked in patches to make loadRecipes return false when errors (such as invalid
keys) are detected, but have NOT made pmConfig fail as loadRecipes legitimately fails
when e.g. a file doesn't contain a recipe.
We should revisit this when we start using psErrorCode not bool as our status variable.
Change History (2)
comment:1 by , 17 years ago
| Priority: | high → low |
|---|---|
| Status: | new → assigned |
comment:2 by , 16 years ago
| Component: | config → psModules |
|---|---|
| Description: | modified (diff) |
| Resolution: | → fixed |
| Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
pmConfig was long-ago changed to check the return value, and the API for loadRecipes was changed to have two bool return values, one for fatal and the other for non-fatal errors
(this does not deny the possible benefits of reworking psLib/etc return values, but that is a larger scale project than this bug).