#765 closed defect (fixed)
row,col / x,y / i,j
| Reported by: | eugene | Owned by: | |
|---|---|---|---|
| Priority: | high | Milestone: | |
| Component: | mathtypes | Version: | 0.11.0 |
| Severity: | normal | Keywords: | |
| Cc: |
Description
I am quite concerned about the inconsistency in psLib of col,row, x,y, etc in
the code. In a simple examination, I have found two cases where these concepts
are mis-used. Just to be extremely clear: x (and the index i) should always be
used to refer to a COLUMN and y should always be used to refer to a ROW.
Arguments to functions which refer to both x and y should always be in the order
(x,y). Coefficients associated with an X refer to an image COLUMN, etc. The
ONLY place where we have to be very careful about the order is in the
image->data.XXX[row][col] elements. The image elements are in the order [ROW][COL].
I have found these types of errors in:
psImageSet
psImageGet
psImageFitPolynomial
I find it hard to understand why the testing that is being done has not caught
these errors.
I have fixed psImageGet, psImageSet and psImageFitPolynomial in CVS head.