pmConfigRead() has too many assertions

[jhoblitt]

This function has assertions that prevent it's use and disagree with it's
doxygen description.

[jhoblitt]

patch to allow pmConfigRead() to accept NULLs

[gusciora@…]

I commented out those asserts for now. What should be done in the code if those
aruments are NULL?

[jhoblitt]

The code already does the correct thing when passed in a pointer to a NULL
(search for the config(s)). The assertions must have been added in after the fact.

[gusciora@…]

I tried NULL pointers without the ASSERTS and I received ungraceful exits in all
cases (either seg faults, or memory leaks).

[jhoblitt]

I have working code in the form:

pmConfigRead(&config->site, &config->camera, &config->recipe, &argc, argv, RECIPE);

and I believe Paul does as well. What was leaking and/or where was the segfault
originating?

[gusciora@…]

The seg faults with site=NULL was when it was written to with the
MetaDataConfigParse routine. The memory leaks with *site=NULL where numerous:
about 3 screefuls.

The seg faults with the other args were at various other places. The code in
tst_pmConfig tests all these things (though I commented it out in the current
CVS head).

[jhoblitt]

OK. Lets either leave this bug open or a new one about the segfaults & leaks.
We don't want these issues to be forgotten but please put off investing any
effort in them until all of the outstanding pslib issues are resolved.

[jhoblitt]

Are Georges comments still an issue?

[Paul Price]

The code has changed significantly since this bug was submitted.