IPP Software Navigation Tools IPP Links Communication Pan-STARRS Links

Opened 20 years ago

Closed 20 years ago

#688 closed defect (fixed)

src/objects/pmPSFtry.h declares pmPSFtryMaskValues as an enum, not a type

Reported by: rhl@… Owned by: gusciora@…
Priority: high Milestone:
Component: objects Version: 0.9.0
Severity: normal Keywords:
Cc:

Description

The header file src/objects/pmPSFtry.h declares pmPSFtryMaskValues as an enum, not a type;
i.e. the definition is

enum {

PSFTRY_MASK_CLEAR = 0x00, /< Add comment.
PSFTRY_MASK_OUTLIER = 0x01,
/< 1: outlier in psf polynomial fit (provided by

psPolynomials)

PSFTRY_MASK_EXT_FAIL = 0x02, /< 2: ext model failed to converge
PSFTRY_MASK_PSF_FAIL = 0x04,
/< 3: psf model failed to converge
PSFTRY_MASK_BAD_PHOT = 0x08, /< 4: invalid source photometry
PSFTRY_MASK_ALL = 0x0f,
/< Add comment.

} pmPSFtryMaskValues;

and it needs to be "typedef enum ..." otherwise a copy of a variable called pmPSFtryMaskValues
is created in each file that includes this header (which isn't a good idea in a shared library)

Change History (1)

comment:1 by eugene, 20 years ago

Resolution: fixed
Status: newclosed

good point; got it in my rel9_eam_p0 branch

Note: See TracTickets for help on using tickets.