IPP Software Navigation Tools IPP Links Communication Pan-STARRS Links

Opened 21 years ago

Closed 21 years ago

Last modified 20 years ago

#545 closed enhancement (fixed)

autogen.sh should be distributed with a pslib tarball

Reported by: jhoblitt Owned by: robert.desonia@…
Priority: lowest Milestone:
Component: build Version: 0.7.0
Severity: minor Keywords:
Cc:

Description

Please make the following change.

RCS file:
/usr/local/cvs/repositories/pan-starrs/datasys/IPP/psLib/Makefile.am,vretrieving
revision 1.19
diff -u -r1.19 Makefile.am
--- Makefile.am 7 Sep 2005 20:55:07 -0000 1.19
+++ Makefile.am 29 Sep 2005 22:19:34 -0000
@@ -5,7 +5,7 @@

pkgconfigdir = $(libdir)/pkgconfig
pkgconfig_DATA= pslib.pc

-EXTRA_DIST = Doxyfile.in pslib-config.in pslib.pc.in share psParseErrorCodes
psParsePrecessionTable
+EXTRA_DIST = Doxyfile.in pslib-config.in pslib.pc.in share psParseErrorCodes
psParsePrecessionTable autogen.sh

docs: Doxyfile $(prefix)/docs/pslib $(mandir)/man3

$(DOXYGEN)

Change History (5)

comment:1 by robert.desonia@…, 21 years ago

Resolution: invalid
Status: newclosed

I disagree. autogen.sh is only needed for the CVS version where a configure script needs generation.
The distribution tarball does not require autogen.sh as those users are not going to be changing the
autoconf/automake input files. The configure script is to be used as the first step for the distribution,
as is customary.

I see a distinction in the audience of CVS and distribution tarball users. The distribution tarball is for
users/consumers of the library, while CVS users are developers of the library. There is no need for
autogen.sh or configure.ac or Makefile.am files in the distribution, nor is there a need for that type of
user to ever use autoconf/automake/autogen.sh to regenerate the configure script and/or Makefile
templates.

-rdd

comment:2 by jhoblitt, 21 years ago

Resolution: invalid
Status: closedreopened

It's navie to think that someone who's downloaded the tarball won't need to edit
the source code or change the build system. If we wanted to prevent users from
making changes we would be handing out binaries. This is a *source*
distribution we're talking about here and the tarballs are being provided as the
*stable* version.

I just went through the hassle of providing autogen.sh from CVS to someone so
they could fix a trivial build issue. Further, the autogen.sh equivalent file
is distributed by convention with most autotools projects for the exact same
reason. Most of pslib's dependacies follow this convention: gsl (autogen.sh),
fftw (bootstrap.sh) and msyql (BUILD/autorun.sh).

comment:3 by robert.desonia@…, 21 years ago

Resolution: fixed
Status: reopenedclosed

done.

comment:4 by Paul Price, 20 years ago

Keywords: VERIFIED added

Bug has been resolved.... closing.

comment:5 by Paul Price, 20 years ago

Keywords: VERIFIED removed

Bugs have been fixed... closing.

Note: See TracTickets for help on using tickets.