Opened 17 years ago
Closed 16 years ago
#1267 closed defect (fixed)
pmShutterCorrection members not assigned if guess fails causing seg fault
| Reported by: | giebink | Owned by: | eugene |
|---|---|---|---|
| Priority: | high | Milestone: | |
| Component: | psModules | Version: | current |
| Severity: | major | Keywords: | pmShutterCorrectionGuess, seg fault |
| Cc: |
Description
In pmShutterReference (shutterCorrection.c) the call to pmShutterCorrectionFullFit has as an argument the guess returned by the preceding call to pmShutterCorrectionGuess. However, failures in pmShutterCorrectionGuess transfer control to GUESS_ERROR via a goto. At GUESS_ERROR memory is freed but pmShutterCorrection struct members scale, offset, and offref are not assigned. This cause a seg fault when the values are accessed.
Change History (2)
comment:1 by , 16 years ago
| Component: | Modules SDRS → IPP SDRS |
|---|
comment:2 by , 16 years ago
| Component: | IPP SDRS → psModules |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.

Looks like pmShutterCorrectionFullFit now checks for a NULL guess and returns NULL, and the calling function (pmShutterCorrectionMeasure) likewise returns a NULL on a NULL return from pmShutterCorrectionFullFit.
the psTrace after the call to pmShutterCorrectionFullFit in pmShutterCorrectionReference was not protected. This is now only called if the return value is not NULL.
(r27832)