Opened 17 years ago
Closed 17 years ago
#1255 closed defect (fixed)
RA in FITS header is in sexagesimal _degrees_. Change to sexagesimal _hours_
| Reported by: | Michael Wood-Vasey | Owned by: | Paul Price |
|---|---|---|---|
| Priority: | high | Milestone: | |
| Component: | concepts | Version: | |
| Severity: | minor | Keywords: | |
| Cc: | eugene |
Description
The RA in FITS headers for .smf files and .ch.fits files are in sexigesimal _degrees_, which is not a convention that anyone I know uses for RA. While I'm all for decimal degrees for RA and Dec and think SDSS has done an excellent job in setting that as the new standard, sexigesimal hours remains the only convention for sexigesimal expression of RA.
This is going to cause confusion if left unchanged.
At the very least, the FITS header comment field for RA should indicate that RA is in sexigesimal degrees for that record.
Change History (3)
comment:1 by , 17 years ago
| Cc: | added |
|---|---|
| Component: | camera → ippconfig |
comment:2 by , 17 years ago
| Priority: | low → high |
|---|
I believe it's important to fix this before we start releasing lots of data. No-one wants code that has to handle a particular convention for the first few weeks of the survey and different for the rest. I know the IPP team will have to have all sorts of stuff like this (and already does), but I think we can isolate the larger consortium from this.
comment:3 by , 17 years ago
| Component: | ippconfig → concepts |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
| Summary: | RA in FITS header is in sexigesimal _degrees_. Change to sexigesimal _hours_ → RA in FITS header is in sexagesimal _degrees_. Change to sexagesimal _hours_ |
I have changed the code that formats concept values to only write sexagesimal format if we're writing RA in hours and Dec in degrees. In all other cases, we write decimal for both and it's up to the user to figure out what it is.
psString ra = psMetadataLookupStr(&mdok, formats, "FPA.RA"); // Format for RA
psString dec = psMetadataLookupStr(&mdok, formats, "FPA.DEC"); // Format for Dec
if (ra && strcasecmp(ra, "HOURS") == 0 && dec && strcasecmp(dec, "DEGREES") == 0) {
sexagesimal = true;
}
Fixed on trunk, r24419.

Gene, is it going to affect DVO if I change the SMF files to use hours for the RA?
Currently, they are:
I believe this is because the GPC1 MEF format specifies
FORMATS METADATA FPA.RA STR DEGREES FPA.DEC STR DEGREES # ... END