ppSub -stamps option doesn't load stamps from file.

[Michael Wood-Vasey]

I've been trying to use the ppSub -stamps xylist.txt option but it doesn't seem to work for me. This is using the 20090508 SVN HEAD. I've tried using files like

1142.493652,850.838623
4071.582520,945.288025
3920.500977,443.246429
3988.441406,936.689392
1405.281616,938.831421
270.799316,347.087769
2643.310059,469.945343

or

1142.493652 850.838623
4071.582520 945.288025
3920.500977 443.246429
3988.441406 936.689392
1405.281616 938.831421
270.799316 347.087769
2643.310059 469.945343

The help says a file with 'x,y on each line' list, so I wasn't sure which was meant. I assume this is supposed to work?

Being able to control the stamp selection is pretty important in verifying and improving the subtractions.

[Michael Wood-Vasey]

After discussions with Paul I changed the following lines in pmSubtractionMatch.c

if (stampsName && strlen(stampsName) > 0) {

stamps = pmSubtractionStampsSetFromFile(stampsName, ro1->image, subMask, region, size,

footprint, stampSpacing, subMode);

} else if (sources) {

stamps = pmSubtractionStampsSetFromSources(sources, ro1->image, subMask, region, size,

footprint, stampSpacing, subMode);

}

to do the checking in this order rather the previously where it never read stamps if there were sources .cmf files specified.

Now, however, while the sources picked are different, there are still half of the sources that were not in the stamps file being picked for sources in the convolution. Where should I look further track this down. Cursory looks at pmSubtractionStamps didn't make it immediately clear to me where this was actually done.

[Paul Price]

Try using the "-debug" option, which should produce ds9 region files at different places in the process.

[Michael Wood-Vasey]

That's exactly what I'm doing to show that the stamps are not what they should be.

ppSub -refimage wbb9.061017_0534.135_4.sw.fits -refvariance wbb9.061017_0534.135_4.sw.var.fits -inimage wbb9.071004_0524.038_4.sw.fits -invariance wbb9.071004_0524.038_4.sw.var.fits -threads 2 -photometry -inverse -refsources wbb9.061017_0534.135_4.sw.good.cmf -insources wbb9.071004_0524.038_4.sw.good.cmf testout_stamp2 -stamps stamps.xy -debug -trace psModules.imcombine 10

This is ESSENCE data. I have bundled up the entire list of files to reproduce at

​http://www.phyast.pitt.edu/~wmwv/PS1/sub_test_20090513.tgz

Sorry I couldn't attach the files (even the small ones). Trac configuration problem.

[Paul Price]

Doesn't look like MWV committed anything. Inverted preference order for stamps source (specified sources by user first, general sources from photometry second). ppSub wasn't using the correct source for the name of the stamps file from the user (artifact of recent reorganisation). Fixed on truck, r24181.

[Michael Wood-Vasey]

I didn't commit because while I agree with the change the resulting behavior is still not what I think it should be. The generated stamp list is not solely from the input 'stamps.xy' file.

I've re-opened the bug, although I'm happy to list it in a new ticket if you'd rather.

[Paul Price]

I've verified that this issue was fixed at r24181. I made more changes than what is in your first comment. Please check that my fix works; I think you'll find it will.

[Michael Wood-Vasey]

Yes, fixed.

Thank you.