chip_imfile.pl : bin1,bin2,stats output files are not optional

[rodney]

chip_imfile.pl checks the metadata recipe to see if a given output file is expected (i.e. if the recipe sets that output file type to TRUE). This check is not performed for the PPIMAGE.BIN1 .BIN2 and .STATS files:

Line 177:

my $outputWeightExpect = metadataLookupBool($recipeData, 'CHIP.WEIGHT.FITS');

if ($outputWeightExpect) {

&my_die("Couldn't find expected output file: $outputWeight\n", $exp_id, $chip_id, $class_id, $PS_EXIT_SYS_ERROR) unless $ipprc->file_exists($outputWeight);

}

&my_die("Couldn't find expected output file: $outputBin1\n", $exp_id, $chip_id, $class_id, $PS_EXIT_SYS_ERROR) unless $ipprc->file_exists($outputBin1);
&my_die("Couldn't find expected output file: $outputBin2\n", $exp_id, $chip_id, $class_id, $PS_EXIT_SYS_ERROR) unless $ipprc->file_exists($outputBin2);
&my_die("Couldn't find expected output file: $outputStats\n", $exp_id, $chip_id, $class_id, $PS_EXIT_SYS_ERROR) unless $ipprc->file_exists($outputStats);

Either the recipe checks should be inserted, or the options should be disallowed in the metadata config files ppImage.config.

[Paul Price]

The BIN1, BIN2 and STATS are an essential part of the pipeline. They can be turned off for ppImage, but this stage requires them, so it is right to assert on their existence.