Opened 18 years ago
Closed 18 years ago
#1016 closed defect (fixed)
Numerical Recipes code to be removed
| Reported by: | Paul Price | Owned by: | eugene |
|---|---|---|---|
| Priority: | high | Milestone: | |
| Component: | Ohana | Version: | unspecified |
| Severity: | blocker | Keywords: | |
| Cc: |
Description
Within Ohana, there are several instances of code directly derived from Numerical Recipes code. These must be removed to be in compliance with copyright.
Multiple sort functions ("sort*.c" --- I haven't checked all, but several that I did check were NR; compare hpsort on p337 of NR in C Edition 2)
Ohana/src/opihi/lib.data/fft.c (compare four1 on p507)
Ohana/src/libohana/src/gaussj.c (compare gaussj on p39)
Ohana/src/opihi/lib.data/powell.c (compare powell on p417 and linmin on
p419; though I don't think this file gets built and it's not used by anything)
powell.c can simply be deleted, and we can probably find replacements for the others in GSL, if we distribute Ohana under GPL.
Note:
See TracTickets
for help on using tickets.
the offending code appears to have been removed