Changeset 9770 for trunk/psModules/src/objects/pmPSF_IO.c

Timestamp:

Oct 28, 2006, 10:23:51 AM (20 years ago)

Author:

magnier

Message:

This is an important change to the PSF shape model.

• I have changed the definition of the elliptical contour parameters

(PM_PAR_SXX,SYY are now sigma_x,y/sqrt(2), rather than
sqrt(2)/sigma_x.

• I have changed the way in which the SXY term is modelled. rather

than fit SXY to a polynomial, I now fit SXY / (1/SXX^{2 + 1/SYY}2)^{2.
this representation is more likely to be well-described by a
polynomial. the other form is likely to vary as xy/r}N rather than xy
r^N.

these changes imply that the models all need to treat the SXX,SYY,SXY
terms in the same fashion (ie, fitting a contour of the form (x/SXX)<sup>2
+ (y/SYY)</sup>2 + SXY*x*y). If an arbitrary model uses some other meaning
for SXX, SYY, SXY, then it will have to define its own exceptions in
the functions pmPSFFromModels and pmModelFromPSF (the latter has an
implementation for each model already).

• I have cleaned up the pmModel_NAME.c functions to use the #define names

for the parameters (PM_PAR_XXX) everywhere, and to use #def names for
the functions. this latter change makes it easy to specify the model
function names in a single location.

File:

• trunk/psModules/src/objects/pmPSF_IO.c (modified) (3 diffs)

trunk/psModules/src/objects/pmPSF_IO.c

@@ -6 +6 @@
  *  @author EAM, IfA
  *
- *  @version $Revision: 1.7 $ $Name: not supported by cvs2svn $
- *  @date $Date: 2006-10-14 00:56:13 $
+ *  @version $Revision: 1.8 $ $Name: not supported by cvs2svn $
+ *  @date $Date: 2006-10-28 20:23:51 $
  *
  *  Copyright 2004 Maui High Performance Computing Center, University of Hawaii
@@ -50 +50 @@
     psMetadataAdd (metadata, PS_LIST_TAIL, "PSF_MODEL_NPAR", PS_DATA_S32, "PSF model parameter count", nPar);
 
-    for (int i = 0; i < nPar - 4; i++) {
-        psPolynomial2D *poly = psf->params->data[i];
+    for (int i = 0; i < nPar; i++) {
+        psPolynomial2D *poly = psf->params_NEW->data[i];
+        if (poly == NULL)
+            continue;
         psPolynomial2DtoMetadata (metadata, poly, "PSF_PAR%02d", i);
     }
@@ -87 +89 @@
         psAbort ("read PSF" , "mismatch model par count");
 
-    for (int i = 0; i < nPar - 4; i++) {
+    // un-fitted terms, not in the Metadata, are left NULL
+    // XXX add a double-check of the expected number?
+    for (int i = 0; i < nPar; i++) {
         sprintf (keyword, "PSF_PAR%02d", i);
         psMetadata *folder = psMetadataLookupPtr (&status, metadata, keyword);
+        if (!status)
+            continue;
         psPolynomial2D *poly = psPolynomial2DfromMetadata (folder);
-        psFree (psf->params->data[i]);
-        psf->params->data[i] = poly;
+        psFree (psf->params_NEW->data[i]);
+        psf->params_NEW->data[i] = poly;
     }
     sprintf (keyword, "APTREND");