Changeset 6311 for trunk/psphot/src/pmCellSetMask.c

Timestamp:

Feb 2, 2006, 1:30:35 PM (20 years ago)

Author:

eugene

Message:

updated to use new image/subimage/region coordinate consistency

File:

• trunk/psphot/src/pmCellSetMask.c (modified) (2 diffs)

trunk/psphot/src/pmCellSetMask.c

@@ -6 +6 @@
 
     // mask the excluded outer pixels
+    // these coordinates refer to the parent image
+    // these bounds will saturate on the subimage
+    // negative upper bounds will subtract from the *subimage*
     float XMIN  = psMetadataLookupF32 (&status, recipe, "XMIN");
     float XMAX  = psMetadataLookupF32 (&status, recipe, "XMAX");
@@ -17 +20 @@
         pmReadout *readout = readouts->data[i]; // The readout of interest
 
+        // psRegionForImage creates a region for the subimage, not the parent
+        // XXX I propose that psRegionForImage treat the region as referring to the parent...
         psRegion keep = psRegionForImage (readout->image, valid);
+
+        // psImageKeepRegion assumes the region refers to the parent coordinates
         psImageKeepRegion (readout->mask, keep, "OR", PSPHOT_MASK_INVALID);
     }