Changeset 6193 for trunk/psLib/src/math/psStats.c

Timestamp:

Jan 25, 2006, 2:31:19 PM (20 years ago)

Author:

gusciora

Message:

Several mods mostly to the psPolynomial fitting routines.

File:

• trunk/psLib/src/math/psStats.c (modified) (9 diffs)

trunk/psLib/src/math/psStats.c

@@ -14 +14 @@
  *      stats->binsize
  *
- *
- *
- *
- *  @version $Revision: 1.160 $ $Name: not supported by cvs2svn $
- *  @date $Date: 2006-01-23 22:25:31 $
+ *  @version $Revision: 1.161 $ $Name: not supported by cvs2svn $
+ *  @date $Date: 2006-01-26 00:31:19 $
  *
  *  Copyright 2004 Maui High Performance Computing Center, University of Hawaii
@@ -574 +571 @@
     nValues = p_psVectorNValues(myVector, maskVector, maskVal, stats);
 
-    // XXX: Is a warning message appropriate?  What value should we set the
-    // sampleMedian to?  Should we generate an error?
     if (nValues <= 0) {
         psLogMsg(__func__, PS_LOG_WARN, "WARNING: p_psVectorSampleMedian(): no valid elements in input vector.\n");
@@ -784 +779 @@
 Returns
     NULL
- 
-XXX: Use static vectors.
  *****************************************************************************/
 bool p_psVectorSampleQuartiles(const psVector* myVector,
@@ -1133 +1126 @@
         p_psMemSetPersistent(statsTmp, true);
     } else {
-        // XXX EAM : initialize structure if already allocated
+        // EAM : initialize structure if already allocated
         statsTmp->sampleMean = NAN;
         statsTmp->sampleMedian = NAN;
@@ -1226 +1219 @@
         // Otherwise, use the new results and continue.
         if (isnan(statsTmp->sampleMean) || isnan(statsTmp->sampleStdev)) {
-            // Exit loop.  XXX: Should we throw an error/warning here?
+            // Exit loop.  XXX: throw an error/warning here?
             iter = stats->clipIter;
             rc = -1;
@@ -1487 +1480 @@
         //
         // XXX: This routine should probably be rewritten in a more general fashion
-        // so that the folloiwng checks are not necessary.
+        // so that the following checks are not necessary.
         //
         if (y->data.F64[0] < y->data.F64[1]) {
@@ -1591 +1584 @@
     psTrace(__func__, 5, "---- %s(%f) end ----\n", __func__, tmpFloat);
     return(tmpFloat);
-}
-
-/*****************************************************************************
-XXX: Is there a psLib function for this?
- *****************************************************************************/
-psVector *PsVectorDup(psVector *in)
-{
-    psTrace(__func__, 4, "---- %s() begin ----\n", __func__);
-    PS_ASSERT_VECTOR_NON_NULL(in, NULL);
-    psVector *out = psVectorAlloc(in->n, in->type.type);
-
-    if (in->type.type == PS_TYPE_F32) {
-        for (psS32 i = 0 ; i < in->n ; i++) {
-            out->data.F32[i] = in->data.F32[i];
-        }
-    } else if (in->type.type == PS_TYPE_F64) {
-        for (psS32 i = 0 ; i < in->n ; i++) {
-            out->data.F64[i] = in->data.F64[i];
-        }
-    } else {
-        psError(PS_ERR_UNKNOWN, true, "Unallowable vector type.\n");
-        psTrace(__func__, 4, "---- %s(NULL) end ----\n", __func__);
-        return(NULL);
-    }
-    psTrace(__func__, 4, "---- %s(psVector) end ----\n", __func__);
-    return(out);
 }
 
@@ -1832 +1799 @@
         // ADD: Step 3.
         // Interpolate to the exact 50% position: this is the robust histogram median.
-        // XXX: Check for errors here!
+        // XXX: Check return codes.
         //
         stats->robustMedian = fitQuadraticSearchForYThenReturnX(
@@ -2640 +2607 @@
  
 XXX: Should the default data type be F64?  Since we are buying Opterons...
+ 
+XXX: Use psLib functions instead.
  *****************************************************************************/
 psVector* p_psConvertToF32(psVector* in)