Changeset 41549 for trunk/ippTools/src/warptool.c

Timestamp:

Apr 9, 2021, 4:44:03 PM (5 years ago)

Author:

eugene

Message:

disallow unrestricted queries and add -all option to definebyquery commands and others which would generate very long results if allowed: camtool, chiptool, difftool, dqstatstool, faketool, pubtool, warptool

File:

• trunk/ippTools/src/warptool.c (modified) (6 diffs)

trunk/ippTools/src/warptool.c

@@ -602 +602 @@
     PXOPT_LOOKUP_U64(limit, config->args, "-limit", false, false);
     PXOPT_LOOKUP_BOOL(simple, config->args, "-simple", false);
+    PXOPT_LOOKUP_BOOL(all, config->args, "-all", false);
 
     // find all rawImfiles matching the default query
@@ -614 +615 @@
         psStringAppend(&query, " AND %s", whereClause);
         psFree(whereClause);
+    } else {
+      if (!all) {
+        psError(PXTOOLS_ERR_SYS, false, "unrestricted query not allowed (try -all)");
+        return false;
+      }
     }
     psFree(where);
@@ -930 +936 @@
     PXOPT_LOOKUP_U64(limit, config->args, "-limit", false, false);
     PXOPT_LOOKUP_BOOL(simple, config->args, "-simple", false);
+    PXOPT_LOOKUP_BOOL(all, config->args, "-all", false);
 
     // First find Label's with warpRuns in state new in priority order
@@ -945 +952 @@
         psStringAppend(&labelWhereStr, "\n AND %s", whereClause);
         psFree(whereClause);
+    } else {
+      if (!all) {
+        psError(PXTOOLS_ERR_SYS, false, "unrestricted query not allowed (try -all)");
+        return false;
+      }
     }
     psFree(labelWhere);
@@ -1645 +1657 @@
   PS_ASSERT_PTR_NON_NULL(config, NULL);
   
+  PXOPT_LOOKUP_U64(limit, config->args, "-limit", false, false);
+  PXOPT_LOOKUP_BOOL(simple, config->args, "-simple", false);
+  
   psMetadata *where = psMetadataAlloc();
   PXOPT_COPY_S64(config->args, where, "-warp_id",    "warpSkyfile.warp_id", "==");
@@ -1661 +1676 @@
   PXOPT_LOOKUP_BOOL(all, config->args, "-all", false);
 
-  PXOPT_LOOKUP_U64(limit, config->args, "-limit", false, false);
-  PXOPT_LOOKUP_BOOL(simple, config->args, "-simple", false);
-  
   // find all rawImfiles matching the default query
   psString query = pxDataGet("warptool_tosummary.sql");