Changeset 41549 for trunk/ippTools/src/difftool.c

Timestamp:

Apr 9, 2021, 4:44:03 PM (5 years ago)

Author:

eugene

Message:

disallow unrestricted queries and add -all option to definebyquery commands and others which would generate very long results if allowed: camtool, chiptool, difftool, dqstatstool, faketool, pubtool, warptool

File:

• trunk/ippTools/src/difftool.c (modified) (2 diffs)

trunk/ippTools/src/difftool.c

@@ -471 +471 @@
     PXOPT_LOOKUP_U64(limit, config->args, "-limit", false, false);
     PXOPT_LOOKUP_BOOL(simple, config->args, "-simple", false);
+    PXOPT_LOOKUP_BOOL(all, config->args, "-all", false);
 
     psString query = pxDataGet("difftool_todiffskyfile.sql");
@@ -478 +479 @@
     }
 
-    if (psListLength(where->list)) {
+    if (where && psListLength(where->list)) {
         psString whereClause = psDBGenerateWhereConditionSQL(where, NULL);
         psStringAppend(&query, " AND %s", whereClause);
         psFree(whereClause);
+    } else {
+      if (!all) {
+        psError(PXTOOLS_ERR_SYS, false, "unrestricted query not allowed (try -all");
+        return false;
+      }
     }
     psFree(where);