Changeset 35455 for trunk/psModules/src/objects/pmPSF.c

Timestamp:

Apr 30, 2013, 6:10:41 PM (13 years ago)

Author:

watersc1

Message:

Changes to stacking code:

• New input FWHM clipping algorithm using mixture models
• New recipes/reductions that further reduce FWHM clipping
• pmSubtractionRejectStamps now fits flux/chi^{2 values in log-log space to prevent outliers biasing the fit (and causing images to be rejected due to a small number of bad stamps)}
• pmPSF now correctly chooses between useReff forms as appropriate
• pmPSF change fixes circularization issues in pmReadoutFakeFromSources
• pmPSFEnvelope somewhat more clear about circularization
• Changed debugging in pmSubtractionEquation to add information.

I do not see any conflicts with the ppSub code.

File:

• trunk/psModules/src/objects/pmPSF.c (modified) (3 diffs)

trunk/psModules/src/objects/pmPSF.c

@@ -342 +342 @@
     PS_ASSERT_PTR_NON_NULL(modelPar, axes);
 
-    bool useReff = true;
+    bool useReff = false;
     useReff |= (type == pmModelClassGetType ("PS_MODEL_SERSIC"));
     useReff |= (type == pmModelClassGetType ("PS_MODEL_DEV"));
@@ -350 +350 @@
         shape.sx  = modelPar[PM_PAR_SXX];
         shape.sy  = modelPar[PM_PAR_SYY];
-        shape.sxy = modelPar[PM_PAR_SXY];
+        shape.sxy = modelPar[PM_PAR_SXY]; // This is potentially wrong?
     } else {
         shape.sx  = modelPar[PM_PAR_SXX] / M_SQRT2;
@@ -384 +384 @@
     psEllipseShape shape = psEllipseAxesToShape (axes);
 
-    bool useReff = true;
-    useReff |= pmModelClassGetType ("PS_MODEL_SERSIC");
-    useReff |= pmModelClassGetType ("PS_MODEL_DEV");
-    useReff |= pmModelClassGetType ("PS_MODEL_EXP");
+    bool useReff = false;
+    useReff |= ( type == pmModelClassGetType ("PS_MODEL_SERSIC"));
+    useReff |= ( type == pmModelClassGetType ("PS_MODEL_DEV"));
+    useReff |= ( type == pmModelClassGetType ("PS_MODEL_EXP"));
 
     if (useReff) {
         modelPar[PM_PAR_SXX] = shape.sx;
         modelPar[PM_PAR_SYY] = shape.sy;
-        modelPar[PM_PAR_SXY] = shape.sxy;
+        modelPar[PM_PAR_SXY] = shape.sxy; // This is potentially wrong?
     } else {
         modelPar[PM_PAR_SXX] = shape.sx * M_SQRT2;