Changeset 32481 for trunk/psLib/src/sys/psThread.c

Timestamp:

Oct 4, 2011, 12:15:49 PM (15 years ago)

Author:

bills

Message:

Per suggestion from Paul Price. Declare pending and done pointers volatile since they can
be changed by multiple threads.

File:

• trunk/psLib/src/sys/psThread.c (modified) (6 diffs)

trunk/psLib/src/sys/psThread.c

@@ -36 +36 @@
 static pthread_mutex_t mutex = PTHREAD_MUTEX_INITIALIZER; // Mutex for locking threads
 
-static psList *pending = NULL;          // queue of pending jobs
-static psList *done = NULL;             // queue of done jobs
+static volatile psList *pending = NULL; // queue of pending jobs
+static volatile psList *done = NULL;    // queue of done jobs
 static pthread_t *threads = NULL;       // array of the POSIX thread handles
 static psArray *pool = NULL;            // array of defined threads
@@ -116 +116 @@
             done = psListAlloc(NULL);
         }
-        psListAdd(done, PS_LIST_TAIL, job);
+        psListAdd((psList *)done, PS_LIST_TAIL, job);
         psFree(job);
         return task->function(job);
@@ -125 +125 @@
         pending = psListAlloc(NULL);
     }
-    psListAdd(pending, PS_LIST_TAIL, job);
+    psListAdd((psList *)pending, PS_LIST_TAIL, job);
     psFree(job);
     psThreadUnlock();
@@ -139 +139 @@
     }
 
-    psThreadJob *job = psListGetAndRemove(pending, PS_LIST_HEAD);
+    psThreadJob *job = psListGetAndRemove((psList *)pending, PS_LIST_HEAD);
     return job;
 }
@@ -150 +150 @@
     }
 
-    psThreadJob *job = psListGetAndRemove(done, PS_LIST_HEAD);
+    psThreadJob *job = psListGetAndRemove((psList *) done, PS_LIST_HEAD);
     return job;
 }
@@ -253 +253 @@
             done = psListAlloc(NULL);
         }
-        psListAdd(done, PS_LIST_TAIL, job);
+        psListAdd((psList *)done, PS_LIST_TAIL, job);
         psFree(job);