Changeset 30031 for trunk/psLib/src/imageops

Timestamp:

Dec 14, 2010, 9:29:23 AM (15 years ago)

Author:

eugene

Message:

modifications to psImageMapFit to allow for unfittable data (at a given resolution)

Location:

trunk/psLib/src/imageops

Files:

• . (modified) (1 prop)
• psImageMapFit.c (modified) (13 diffs)
• psImageMapFit.h (modified) (4 diffs)

trunk/psLib/src/imageops/psImageMapFit.c

@@ -48 +48 @@
 
 // map defines the output image dimensions and scaling.
-bool psImageMapFit(psImageMap *map, const psVector *mask, psVectorMaskType maskValue,
+bool psImageMapFit(bool *goodFit, psImageMap *map, const psVector *mask, psVectorMaskType maskValue,
                    const psVector *x, const psVector *y, const psVector *f, const psVector *df)
 {
     // XXX Add Asserts
+
+    *goodFit = false;
 
     // dimensions of the output map image
@@ -81 +83 @@
         map->map->data.F32[0][0]   = psStatsGetValue(map->stats, mean);
         map->error->data.F32[0][0] = psStatsGetValue(map->stats, stdev);
+        *goodFit = true;
         return true;
     }
@@ -86 +89 @@
     if (Nx == 1) {
         bool status;
-        status = psImageMapFit1DinY (map, mask, maskValue, x, y, f, df);
+        status = psImageMapFit1DinY (goodFit, map, mask, maskValue, x, y, f, df);
         return status;
     }
     if (Ny == 1) {
         bool status;
-        status = psImageMapFit1DinX (map, mask, maskValue, x, y, f, df);
+        status = psImageMapFit1DinX (goodFit, map, mask, maskValue, x, y, f, df);
         return status;
     }
@@ -310 +313 @@
 
     if (!psMatrixGJSolve(A, B)) {
-        psError(PS_ERR_UNKNOWN, false, "Could not solve linear equations.  Returning NULL.\n");
         psFree (A);
         psFree (B);
-        return false;
+        return true;
     }
 
@@ -337 +339 @@
     psFree (Empty);
 
+    *goodFit = true;
     return true;
 }
 
 // measure residuals on each pass and clip outliers based on stats
-bool psImageMapClipFit(psImageMap *map, psStats *stats, psVector *inMask, psVectorMaskType maskValue,
+bool psImageMapClipFit(bool *goodFit, psImageMap *map, psStats *stats, psVector *inMask, psVectorMaskType maskValue,
                        const psVector *x, const psVector *y, const psVector *f, const psVector *df)
 {
@@ -351 +354 @@
     psAssert(f, "impossible");
 
+    *goodFit = false;
+
     // the user supplies one of various stats option pairs,
     // determine the desired mean and stdev STATS options:
@@ -393 +398 @@
         psTrace("psLib.imageops", 6, "Loop iteration %d.  Calling psImageMapFit()\n", N);
         psS32 Nkeep = 0;
-        if (!psImageMapFit(map, mask, maskValue, x, y, f, df)) {
+        if (!psImageMapFit(goodFit, map, mask, maskValue, x, y, f, df)) {
             psError(PS_ERR_UNKNOWN, false, "Could not fit image map.\n");
             psFree(resid);
@@ -399 +404 @@
             return false;
         }
+        if (!goodFit) {
+            psWarning ("bad fit to image map, try something else");
+            return true;
+        }
 
         psVector *fit = psImageMapEvalVector(map, mask, maskValue, x, y);
@@ -454 +463 @@
     psFree(resid);
     if (!inMask) psFree (mask);
+    *goodFit = true; // XXX probably don't need to set this (set by psImageMapFit)
     return true;
 }
 
 // map defines the output image dimensions and scaling.
-bool psImageMapFit1DinY(psImageMap *map, const psVector *mask, psVectorMaskType maskValue,
+bool psImageMapFit1DinY(bool *goodFit, psImageMap *map, const psVector *mask, psVectorMaskType maskValue,
                         const psVector *x, const psVector *y, const psVector *f, const psVector *df)
 {
     // XXX Add Asserts
     assert (map->binning->nXruff == 1);
+
+    *goodFit = false;
 
     // dimensions of the output map image
@@ -578 +590 @@
 
     if (!psMatrixGJSolve(A, B)) {
-        psError(PS_ERR_UNKNOWN, false, "Could not solve linear equations.\n");
         psFree (A);
         psFree (B);
         psFree (Empty);
-        return false;
+        return true;
     }
 
@@ -602 +613 @@
     psFree (Empty);
 
+    *goodFit = true;
     return true;
 }
 
 // map defines the output image dimensions and scaling.
-bool psImageMapFit1DinX(psImageMap *map, const psVector *mask, psVectorMaskType maskValue,
+bool psImageMapFit1DinX(bool *goodFit, psImageMap *map, const psVector *mask, psVectorMaskType maskValue,
                         const psVector *x, const psVector *y, const psVector *f, const psVector *df)
 {
     // XXX Add Asserts
     assert (map->binning->nYruff == 1);
+
+    *goodFit = false;
 
     // dimensions of the output map image
@@ -726 +740 @@
 
     if (!psMatrixGJSolve(A, B)) {
-        psError(PS_ERR_UNKNOWN, false, "Could not solve linear equations..\n");
         psFree (A);
         psFree (B);
         psFree (Empty);
-        return false;
+        return true;
     }
 
@@ -750 +763 @@
     psFree (Empty);
 
+    *goodFit = true;
     return true;
 }

trunk/psLib/src/imageops/psImageMapFit.h

@@ -8 +8 @@
 
 // fit the image map to a set of points
-bool psImageMapFit(psImageMap *map,
+bool psImageMapFit(bool *goodFit, 
+                   psImageMap *map,
                    const psVector *mask,
                    psVectorMaskType maskValue, // 
@@ -18 +19 @@
 
 // fit the image map to a set of points
-bool psImageMapClipFit(psImageMap *map,
+bool psImageMapClipFit(bool *goodFit, 
+                       psImageMap *map,
                        psStats *stats,
                        psVector *mask,  // WARNING: Mask is modified!
@@ -28 +30 @@
     );
 
-bool psImageMapFit1DinY(psImageMap *map,
+bool psImageMapFit1DinY(bool *goodFit, 
+                        psImageMap *map,
                         const psVector *mask,
                         psVectorMaskType maskValue,
@@ -37 +40 @@
     );
 
-bool psImageMapFit1DinX(psImageMap *map,
+bool psImageMapFit1DinX(bool *goodFit, 
+                        psImageMap *map,
                         const psVector *mask,
                         psVectorMaskType maskValue,