Changeset 30029 for branches/eam_branches/ipp-20101205/psModules/src/objects/pmTrend2D.c

Timestamp:

Dec 14, 2010, 9:01:22 AM (15 years ago)

Author:

eugene

Message:

update to use modified psImageMapFit APIs

File:

• branches/eam_branches/ipp-20101205/psModules/src/objects/pmTrend2D.c (modified) (4 diffs)

branches/eam_branches/ipp-20101205/psModules/src/objects/pmTrend2D.c

@@ -179 +179 @@
 }
 
-bool pmTrend2DFit(pmTrend2D *trend, psVector *mask, psVectorMaskType maskVal, const psVector *x,
+bool pmTrend2DFit(bool *goodFit, pmTrend2D *trend, psVector *mask, psVectorMaskType maskVal, const psVector *x,
                   const psVector *y, const psVector *f, const psVector *df)
 {
@@ -189 +189 @@
 
     bool status = false;
-    bool goodFit = false;
+    *goodFit = false;
+    // for the psImageMap fit, it is possible to have valid data but no valid solution for
+    // example, an isolated cell may not be reached from other cells, making the solution
+    // degenerate.  psImageMapFit should probably handle this case, but until it does, we allow
+    // it to fail on the result, but not yield an error (goodFit = false).
+    // psVectorClipFitPolynomial2D can not fail in this way (really?), so goodFit is always
+    // true
 
     switch (trend->mode) {
@@ -198 +204 @@
         // of points in the image, and potentially based on the fractional range of the
         // data?
+        *goodFit = true;
         break;
 
@@ -203 +210 @@
         // XXX supply fraction from trend elements
         // XXX need to add the API which adjusts the scale
-        status = psImageMapClipFit(&goodFit, trend->map, trend->stats, mask, maskVal, x, y, f, df);
+        status = psImageMapClipFit(goodFit, trend->map, trend->stats, mask, maskVal, x, y, f, df);
         break;