Changeset 30012 for branches/eam_branches/ipp-20101205/ppStack/src/ppStackCleanup.c

Timestamp:

Dec 9, 2010, 3:12:30 PM (15 years ago)

Author:

eugene

Message:

add some notes

File:

• branches/eam_branches/ipp-20101205/ppStack/src/ppStackCleanup.c (modified) (3 diffs)

branches/eam_branches/ipp-20101205/ppStack/src/ppStackCleanup.c

@@ -11 +11 @@
 #include "ppStackLoop.h"
 
-
+// XXX poor name : move jpeg & stats to a separate function?
+// ppStackCleanupFiles 
 bool ppStackCleanup(ppStackThreadData *stack, ppStackOptions *options, pmConfig *config)
 {
@@ -20 +21 @@
     psMetadata *recipe = psMetadataLookupMetadata(NULL, config->recipes, PPSTACK_RECIPE); // ppStack recipe
     psAssert(recipe, "We've thrown an error on this before.");
-
-#if 0
-    // Ensure masked regions really look masked
-    {
-        psString maskBadStr = psMetadataLookupStr(NULL, recipe, "MASK.BAD"); // Name of bits for bad
-        psImageMaskType maskBad = pmConfigMaskGet(maskBadStr, config); // Bits to mask for bad pixels
-        if (!pmReadoutMaskApply(options->outRO, maskBad)) {
-            psWarning("Unable to apply mask");
-        }
-    }
-#endif
 
     // Generate binned JPEGs
@@ -92 +82 @@
         options->expRO = NULL;
 
+        // XXX move these close / free operations to the jpeg creation function
         pmFPAview *view = pmFPAviewAlloc(0);// Pointer into FPA hierarchy
         view->chip = view->cell = 0;        // pmFPAviewFreeData doesn't want to deal with readouts