Changeset 29926 for trunk/ppImage/src/ppImageOptions.c

Timestamp:

Dec 5, 2010, 9:21:36 PM (15 years ago)

Author:

eugene

Message:

support for compressed metadata files; clarify rules for constructing a mask; support for modified psphotReadout API; remove some deprecated comments and test prints

File:

• trunk/ppImage/src/ppImageOptions.c (modified) (1 diff)

trunk/ppImage/src/ppImageOptions.c

@@ -301 +301 @@
     options->checkCTE       = psMetadataLookupBool(NULL, recipe, "CHECK.CTE");
 
+    /* doMaskBuild : there are some cases where we require a mask, so we force doMaskBuild to be set even if the user specified 'FALSE'
+     *
+     * doPhotom : a mask is required because it is used to mark the locations of stars
+     *
+     * doNoiseMap : no reason this needs to trigger a mask?
+     * doBias : no reason this needs to trigger a mask?
+     * doOverscan : no reason this needs to trigger a mask?
+     * doDark : no reason this needs to trigger a mask?
+     * doShutter : no reason this needs to trigger a mask?
+     * doFlat : no reason this needs to trigger a mask?
+     */
+
     // even if not requested explicitly, if any of these are set, build an internal mask and variance:
-    if (options->doNoiseMap || options->doBias || options->doOverscan || options->doDark || options->doShutter || options->doFlat ||
-        options->doPhotom) {
-        options->doMaskBuild = true;
+    // XXX we used to automatically generate a mask in all of these cases.
+    // if (options->doNoiseMap || options->doBias || options->doOverscan || options->doDark || options->doShutter || options->doFlat || options->doPhotom) {
+    //     options->doMaskBuild = true;
+    //     options->doVarianceBuild = true;
+    // }
+
+    // photometry and noisemap both require a variance image
+    if (options->doNoiseMap || options->doPhotom) {
         options->doVarianceBuild = true;
-    } else if (options->doMask || options->doBG) {
+    } 
+
+    // photometry, mask, and background all require a mask image
+    if (options->doMask || options->doBG || options->doPhotom) {
         options->doMaskBuild = true;
     }