Changeset 26917 for trunk/psModules/src/imcombine/pmPSFEnvelope.c

Timestamp:

Feb 11, 2010, 4:20:46 PM (16 years ago)

Author:

Paul Price

Message:

Don't test the PSF just in the middle (unless that's all that matters).

File:

• trunk/psModules/src/imcombine/pmPSFEnvelope.c (modified) (3 diffs)

trunk/psModules/src/imcombine/pmPSFEnvelope.c

@@ -152 +152 @@
         // Test PSF
         {
-            bool goodPSF = true;                                                                // Good PSF?
-            pmModelClassSetLimits(PM_MODEL_LIMITS_IGNORE);
-            pmModel *model = pmModelFromPSFforXY(psf, numCols / 2.0, numRows / 2.0, PEAK_FLUX); // Test model
-            if (!model) {
-                goodPSF = false;
-            } else {
-                model->modelSetLimits(PM_MODEL_LIMITS_MODERATE);
-                for (int j = 0; j < model->params->n && goodPSF; j++) {
-                    if (!model->modelLimits(PS_MINIMIZE_PARAM_MIN, j, model->params->data.F32, NULL) ||
-                        !model->modelLimits(PS_MINIMIZE_PARAM_MAX, j, model->params->data.F32, NULL)) {
-                        goodPSF = false;
+            bool goodPSF = false;       // Is there a PSF that we can use?
+            int xNum = PS_MAX(psf->trendNx, 1), yNum = PS_MAX(psf->trendNy, 1); // Number of positions to check
+            for (int j = 0; j < yNum && !goodPSF; j++) {
+                float y = ((float)j + 0.5) / (float)yNum * numRows; // Position on image
+                for (int i = 0; i < xNum && !goodPSF; i++) {
+                    float x = ((float)i + 0.5) / (float)xNum * numCols; // Position on image
+                    pmModelClassSetLimits(PM_MODEL_LIMITS_IGNORE);
+                    pmModel *model = pmModelFromPSFforXY(psf, x, y, PEAK_FLUX); // Test model
+                    if (!model) {
+                        continue;
+                    }
+                    model->modelSetLimits(PM_MODEL_LIMITS_MODERATE);
+                    bool limits = true; // Model within limits?
+                    for (int j = 0; j < model->params->n && limits; j++) {
+                        if (!model->modelLimits(PS_MINIMIZE_PARAM_MIN, j, model->params->data.F32, NULL) ||
+                            !model->modelLimits(PS_MINIMIZE_PARAM_MAX, j, model->params->data.F32, NULL)) {
+                            limits = false;
+                        }
+                    }
+                    psFree(model);
+                    if (limits) {
+                        goodPSF = true;
                     }
                 }
-                psFree(model);
             }
             if (!goodPSF) {
-                psWarning("PSF %d is bad --- not including in envelope calculation.", i);
+                psWarning("PSF %d is completely bad --- not including in envelope calculation.", i);
                 continue;
             }
@@ -175 +185 @@
         pmResiduals *resid = psf->residuals;// PSF residuals
         psf->residuals = NULL;
+        pmModelClassSetLimits(PM_MODEL_LIMITS_MODERATE);
         if (!pmReadoutFakeFromSources(fakeRO, fakeSize, fakeSize, fakes, 0, xOffset, yOffset, psf,
                                       NAN, radius, true, false)) {
@@ -399 +410 @@
 
     pmSourceFitModelInit(SOURCE_FIT_ITERATIONS, 0.01, VARIANCE_VAL, true);
-    pmModelClassSetLimits(PM_MODEL_LIMITS_STRICT);
+    pmModelClassSetLimits(PM_MODEL_LIMITS_STRICT); // Important for getting a good stack target PSF
 
     pmPSFtry *try = pmPSFtryModel(fakes, modelName, options, 0, 0xff);