Changeset 26848 for trunk/ippTools/src/magictool.c

Timestamp:

Feb 10, 2010, 3:24:51 PM (16 years ago)

Author:

bills

Message:

increase the limit on the query of unfinished magicRuns from 100 to 1000
This reduces the likelyhood of nodes with dependents not getting run if the
first N runs have only faulted nodes left to process. The query is cheap
(only magic_id is selected) so this shouldn't cause any performance problem.

File:

• trunk/ippTools/src/magictool.c (modified) (2 diffs)

trunk/ippTools/src/magictool.c

@@ -874 +874 @@
 
     // look for tree nodes that need to be processed
+
+    // first find incomplete magicRuns
     query = pxDataGet("magictool_toprocess_runs.sql");
     if (!query) {
@@ -880 +882 @@
     }
 
+    // we limit the query even though it is cheap (only magic_id is selected)
+
+    // XXX: if the first 1000 unfinished magicRuns have no ready nodes
+    // that haven't faulted, later runs won't get returned even though
+    // they have work to do. When we used a limit of 100 we actually ran
+    // into this problem. Since we're using labels a limit of 1000 will
+    // probably be ok.
     {
-        psString limitString = psDBGenerateLimitSQL( 100 );
+        psString limitString = psDBGenerateLimitSQL( 1000 );
         psStringAppend(&query, " %s", limitString);
         psFree(limitString);