Changeset 19239 for trunk/psModules/src/imcombine/pmStack.c

Timestamp:

Aug 27, 2008, 12:02:35 PM (18 years ago)

Author:

Paul Price

Message:

Caught an important bug: was using the wrong index in comparison.

File:

• trunk/psModules/src/imcombine/pmStack.c (modified) (3 diffs)

trunk/psModules/src/imcombine/pmStack.c

@@ -8 +8 @@
  *  @author GLG, MHPCC
  *
- *  @version $Revision: 1.33 $ $Name: not supported by cvs2svn $
- *  @date $Date: 2008-08-26 02:06:44 $
+ *  @version $Revision: 1.34 $ $Name: not supported by cvs2svn $
+ *  @date $Date: 2008-08-27 22:02:35 $
  *  Copyright 2004-2007 Institute for Astronomy, University of Hawaii
  *
@@ -343 +343 @@
                   // Convert to rejection limits --- saves doing it later.
                   // Using squared rejection limit because it's cheaper than sqrts
-                  rej *= rej;
+                  float rej2 = PS_SQR(rej); // Rejection level squared
                   for (int i = 0; i < num; i++) {
-                      pixelVariances->data.F32[i] = rej * pixelVariances->data.F32[i] *
-                          varFactors->data.F32[i];
+                      pixelVariances->data.F32[i] *= rej2 * varFactors->data.F32[i];
                   }
               }
@@ -380 +379 @@
                       continue;
                   }
-                  float diff = fabsf(pixelData->data.F32[j] - median); // Difference from expected
+                  float diff = pixelData->data.F32[j] - median; // Difference from expected
                   if (useVariance) {
                       // Comparing squares --- cheaper than lots of sqrts
-                      if (PS_SQR(diff) > pixelVariances->data.F32[i]) {
+                      if (PS_SQR(diff) > pixelVariances->data.F32[j]) {
                           MASK_PIXEL_FOR_INSPECTION();
                       }
-                  } else if (diff > limit) {
+                  } else if (fabsf(diff) > limit) {
                       MASK_PIXEL_FOR_INSPECTION();
                   }