Changeset 18336 for trunk/ippTools/src/pxtools.h

Timestamp:

Jun 26, 2008, 3:39:54 PM (18 years ago)

Author:

jhoblitt

Message:

consitently handle *_id fields as numeric values instead of converting back of forth between ints and strings

File:

• trunk/ippTools/src/pxtools.h (modified) (3 diffs)

trunk/ippTools/src/pxtools.h

@@ -36 +36 @@
 #include "pxfake.h"
 #include "pxwarp.h"
-#include "pxio.h"
 #include "pxregister.h"
 #include "pxtag.h"
@@ -109 +108 @@
 type var; \
 { \
-    bool status; \
- \
-    var = psMetadataLookup##suffix(&status, md, key); \
-    if (!status) { \
-        psError(PS_ERR_UNKNOWN, false, "failed to lookup value for %s", key); \
-        return ret; \
-    } \
- \
-    if (required && (var == max)) { \
-        psError(PS_ERR_UNKNOWN, true, "%s is required", key); \
-        return ret; \
-    } \
+    psMetadataItem *item = psMetadataLookup(md, key); \
+    if (!item) { \
+        psError(PS_ERR_UNKNOWN, false, "failed to lookup value for %s", key); \
+        return ret; \
+    } \
+    psAssert(item->comment, "metadata item comment should be defined"); \
+    if (required && (!psStrcasestr(item->comment, "(found)"))) { \
+        psError(PS_ERR_UNKNOWN, true, "%s is required", key); \
+        return ret; \
+    } \
+ \
+    var = item->data.suffix; \
+ \
 }
 
@@ -172 +172 @@
 // XXX the PXOPT_COPY_* macros free 'to' on error
 
-#define PXOPT_COPY_PRIMITIVE(from, to, type, suffix, oldname, newname, comment) \
-{ \
-    bool status = false; \
-    type var = psMetadataLookup##suffix(&status, from, oldname); \
-    if (!status) { \
-        psError(PS_ERR_UNKNOWN, false, "failed to lookup value for " oldname); \
+#define PXOPT_COPY_PRIMITIVE(from, to, type, suffix, oldname, newname, newcomment) \
+{ \
+    psMetadataItem *item = psMetadataLookup(from, oldname); \
+    if (!item) { \
+        psError(PS_ERR_UNKNOWN, false, "failed to lookup value for %s", oldname); \
         return false; \
     } \
-    if (!psMetadataAdd##suffix(to, PS_LIST_TAIL, newname, PS_META_DUPLICATE_OK, comment, var)) { \
-        psError(PS_ERR_UNKNOWN, false, "failed to add item " newname); \
-        psFree(to); \
-        return false; \
+    psAssert(item->comment, "metadata item comment should be defined"); \
+\
+    if (psStrcasestr(item->comment, "(found)")) { \
+        if (!psMetadataAdd##suffix(to, PS_LIST_TAIL, newname, PS_META_DUPLICATE_OK, newcomment, item->data.suffix)) { \
+            psError(PS_ERR_UNKNOWN, false, "failed to add item " newname); \
+            psFree(to); \
+            return false; \
+        } \
     } \
 }