Changeset 17844 for trunk/ippTools/src/pxtables.c

Timestamp:

May 28, 2008, 5:14:42 PM (18 years ago)

Author:

jhoblitt

Message:

make sure that table creation errors propagate

File:

• trunk/ippTools/src/pxtables.c (modified) (5 diffs)

trunk/ippTools/src/pxtables.c

@@ -30 +30 @@
     if (!createFunc(config->dbh)) { \
         psError(PS_ERR_UNKNOWN, false, "dbh access failed"); \
-        status = false; \
+        if (status) { \
+            status = false; \
+        } \
     }
 
@@ -36 +38 @@
     if (!dropFunc(config->dbh)) { \
         psError(PS_ERR_UNKNOWN, false, "dbh access failed"); \
-        status = false; \
+        if (status) { \
+            status = false; \
+        } \
     }
 
@@ -107 +111 @@
     CREATE_TABLE(pstampJobCreateTable);
 
-    return true;
+    return status;
 }
 
@@ -147 +151 @@
     if (!p_psDBRunQuery(config->dbh, "SET FOREIGN_KEY_CHECKS=0")) {
         psError(PS_ERR_UNKNOWN, false, "database error");
-        status = false; 
+        return false;
     }
 
@@ -210 +214 @@
     if (!p_psDBRunQuery(config->dbh, "SET FOREIGN_KEY_CHECKS=1")) {
         psError(PS_ERR_UNKNOWN, false, "database error");
-        status = false; 
+        return false;       
     }