Changeset 16591 for trunk/pstamp/scripts/pstamp_runcommand.sh

Timestamp:

Feb 21, 2008, 6:38:46 PM (18 years ago)

Author:

bills

Message:

Updates to the postage stamp server scripts

File:

• trunk/pstamp/scripts/pstamp_runcommand.sh (modified) (4 diffs)

trunk/pstamp/scripts/pstamp_runcommand.sh

@@ -2 +2 @@
 ###
 #
-# pstampwrapper.sh: 
-# Set up the ipp environment to run a ipp commands on behalf of hte postage stamp
+# pstamp_runcommand.sh: 
+#
+# Set up the ipp environment to run a ipp commands on behalf of the postage stamp
 # server and execute the command given by the argument list 
+# This script is used by cgi or php scripts.
 
 if [[ $# == 0 ]] ;then
@@ -15 +17 @@
 
 # These variables need to be customized for a particular installation
+# XXX: why not pass these on on the command line ?
 export PSCONFDIR=/export/data0/bills/psconfig
-
-# TODO shouldn't need to do this but there seems to be a psconfig problem.
-# Gene fixed this recently
-#export LD_LIBRARY_PATH=/usr/local/lib
 
 WORK_DIR=/export/data1/bills/pstamp/work
@@ -30 +29 @@
 cd $WORK_DIR
 status=$?
-if [[ ! $status ]] ; then
+if [[ $status != 0 ]] ; then
     echo $0 cannot cd to WORK_DIR: $WORK_DIR status: $status >&2
     exit $status
 fi
 
-# TODO: I do this so that I have permissions to modify the files created by 
-# the web server user apache.
-#umask 0
-
 ###
-### configure IPP
+### configure the IPP
 ###
-#export MANPATH=""
 
 source $PSCONFDIR/psconfig.bash default
 status=$?
-if [[ ! $status ]] ; then
+if [[ $status != 0 ]] ; then
     echo error setting up IPP environment >&2
     exit $status
@@ -53 +47 @@
 ###
 ### Add our command directory to the path. 
-### TODO: This won't be necessary once the scripts get installed as part of the IPP
+### XXX: This won't be necessary once the scripts get installed as part of the IPP
 ###
 PATH=${CMD_DIR}:${PATH}
 
-## This test is sort of redundant. 
-## We'll get a more useful error by just going ahead and trying the command
-## or by not suppressing the output from which
+## make sure we are able to run the desired command
+## XXX: This test is sort of redundant. 
+## We'd get a more useful error by just going ahead and trying the command
+## or by not suppressing the error output of which
 if [[ ! -x `which $1 2> /dev/null` ]] ;then
     status=$?