Changeset 16444 for trunk/Ohana/src/opihi/lib.shell/macro_create.c

Timestamp:

Feb 13, 2008, 3:27:51 PM (18 years ago)

Author:

eugene

Message:

allocate help, plug leak, set real to false

File:

• trunk/Ohana/src/opihi/lib.shell/macro_create.c (modified) (4 diffs)

trunk/Ohana/src/opihi/lib.shell/macro_create.c

@@ -3 +3 @@
 # define prompt "> "
 int macro_exec   PROTO((int, char **));
-
-static char helpline[] = "(macro)";
 
 int macro_create (int argc, char **argv) {
@@ -13 +11 @@
   Macro *macro;
 
-  help = helpline;
   if ((N = get_argument (argc, argv, "-c"))) {
     remove_argument (N, &argc, argv);
     help = strcreate(argv[N]);
     remove_argument (N, &argc, argv);
+  } else {
+    help = strcreate ("(macro)");
   }
 
@@ -41 +40 @@
   if (macro == NULL) { /**** New Macro ****/
     ALLOCATE (cmd, Command, 1);
+    cmd[0].real = FALSE;
     cmd[0].name = strcreate (argv[1]);
     cmd[0].help = help;
@@ -49 +49 @@
   } else { /**** Old Macro ****/
     /* replace existing command help with new value */
-    if (cmd[0].help != helpline) 
-      free (cmd[0].help);
+    free (cmd[0].help);
     cmd[0].help = help;
   }