Changeset 15264 for trunk/DataStore/scripts/dsget

Timestamp:

Oct 9, 2007, 1:20:33 PM (19 years ago)

Author:

jhoblitt

Message:

create the path to the download location as nessicary
expand the tmp file template
check for file download checksum problems

File:

• trunk/DataStore/scripts/dsget (modified) (5 diffs)

trunk/DataStore/scripts/dsget

@@ -3 +3 @@
 # Copyright (C) 2006  Joshua Hoblitt
 #
-# $Id: dsget,v 1.6 2007-09-28 21:10:58 jhoblitt Exp $
+# $Id: dsget,v 1.7 2007-10-09 23:20:33 jhoblitt Exp $
 
 use strict;
@@ -12 +12 @@
 
 use DataStore;
+use File::Path qw( mkpath );
 use File::Temp ();
 use File::Basename qw( basename dirname );
@@ -46 +47 @@
 $p{md5sum} = $md5 if defined $md5;
 
+my $dirname = dirname($filename);
+
+if (!-d $dirname) {
+    # create path and possibly fix up permissions
+    mkpath([$dirname], 1, 0775);
+}
+
 # can we truely write to filename?
 {
@@ -62 +70 @@
 }
 
-my $dirname = dirname($filename);
-
-if (!-d $dirname) {
-    # create path and possibly fix up permissions
-    mkpath([$dirname], 1, 0775);
-}
-
 my $tmp = File::Temp->new(
     DIR         => $dirname,
-    TEMPLATE    => '.' . basename($filename) . 'XXXX',
+    TEMPLATE    => '.' . basename($filename) . '.XXXXXXXX',
     SUFFIX      => '.tmp',
     UNLINK      => 1,
@@ -82 +83 @@
 die "request failed" unless defined $response;
 die "request failed: ", $response->status_line unless $response->is_success;
+die "checksum failed" unless $response->filename;
 
 # file retreival succeed