Changeset 15216 for trunk/ppImage/src/ppImageLoop.c

Timestamp:

Oct 4, 2007, 9:55:03 AM (19 years ago)

Author:

eugene

Message:

clean up error handling on pmFPAfileIO

File:

• trunk/ppImage/src/ppImageLoop.c (modified) (10 diffs)

trunk/ppImage/src/ppImageLoop.c

@@ -4 +4 @@
 
 #include "ppImage.h"
+
+# define ESCAPE(MESSAGE) { \
+  psError(PS_ERR_UNKNOWN, false, MESSAGE); \
+  psFree (view); \
+  return false; \
+}
 
 bool ppImageLoop (pmConfig *config, ppImageOptions *options) {
@@ -23 +29 @@
 
     // files associated with the science image
-    if (!pmFPAfileIOChecks(config, view, PM_FPA_BEFORE)) {
-        psFree (view);
-        return false;
-    }
+    if (!pmFPAfileIOChecks(config, view, PM_FPA_BEFORE)) ESCAPE ("load failure for FPA");
 
     while ((chip = pmFPAviewNextChip(view, input->fpa, 1)) != NULL) {
@@ -33 +36 @@
             continue;
         }
-
-        if (!pmFPAfileIOChecks(config, view, PM_FPA_BEFORE)) {
-            psFree (view);
-            return false;
-        }
+        if (!pmFPAfileIOChecks(config, view, PM_FPA_BEFORE)) ESCAPE ("load failure for Chip");
 
         while ((cell = pmFPAviewNextCell(view, input->fpa, 1)) != NULL) {
@@ -44 +43 @@
                 continue;
             }
-            if (!pmFPAfileIOChecks(config, view, PM_FPA_BEFORE)) {
-                psFree (view);
-                return false;
-            }
+            if (!pmFPAfileIOChecks(config, view, PM_FPA_BEFORE)) ESCAPE ("load failure for Cell");
 
             // Put version information into the header
@@ -59 +55 @@
             // process each of the readouts
             while ((readout = pmFPAviewNextReadout (view, input->fpa, 1)) != NULL) {
-                if (!pmFPAfileIOChecks(config, view, PM_FPA_BEFORE)) {
-                    psFree (view);
-                    return false;
-                }
+                if (!pmFPAfileIOChecks(config, view, PM_FPA_BEFORE)) ESCAPE ("load failure for Readout");
                 if (!readout->data_exists) {
                     continue;
@@ -68 +61 @@
 
                 // perform the detrend analysis
-                if (!ppImageDetrendReadout(config, options, view)) {
-                    psError(PS_ERR_UNKNOWN, false, "Unable to detrend readout.\n");
-                    psFree (view);
-                    return false;
-                }
-
+                if (!ppImageDetrendReadout(config, options, view)) 
+                    ESCAPE ("Unable to detrend readout");
             }
         }
@@ -79 +68 @@
         // Apply the fringe correction
         if (options->doFringe) {
-            if (!ppImageDetrendFringeApply (config, chip, view, options)) {
-                psFree (view);
-                return false;
-            }
+            if (!ppImageDetrendFringeApply (config, chip, view, options)) 
+                ESCAPE ("Unable to defringe");
         }
         
         // measure various statistics for this image
-        if (!ppImagePixelStats (config, options, view)) {
-            psError(PS_ERR_UNEXPECTED_NULL, true, "Unable to measures stats for image");
-            psFree (view);
-            return false;
-        }
+        if (!ppImagePixelStats (config, options, view)) 
+            ESCAPE ("Unable to measures stats for image");
 
-        if (!ppImageMosaicChip(config, options, view, "PPIMAGE.CHIP", "PPIMAGE.OUTPUT")) {
-            psError(PS_ERR_UNKNOWN, false, "Unable to mosaic chip.\n");
-            psFree (view);
-            return false;
-        }
-        if (!ppImageRebinChip(config, view, "PPIMAGE.BIN1")) {
-            psError(PS_ERR_UNKNOWN, false, "Unable to bin chip.\n");
-            psFree (view);
-            return false;
-        }
-        if (!ppImageRebinChip(config, view, "PPIMAGE.BIN2")) {
-            psError(PS_ERR_UNKNOWN, false, "Unable to bin chip.\n");
-            psFree (view);
-            return false;
-        }
+        if (!ppImageMosaicChip(config, options, view, "PPIMAGE.CHIP", "PPIMAGE.OUTPUT"))
+            ESCAPE ("Unable to mosaic chip");
+
+        if (!ppImageRebinChip(config, view, "PPIMAGE.BIN1"))
+            ESCAPE ("Unable to bin chip (level 1).");
+
+        if (!ppImageRebinChip(config, view, "PPIMAGE.BIN2"))
+            ESCAPE ("Unable to bin chip (level 2).");
 
         // we perform photometry on the readouts of this chip in the output
         if (options->doPhotom) {
-            if (!ppImagePhotom(config, view)) {
-                psError(PS_ERR_UNKNOWN, false, "error running photometry.\n");
-                psFree (view);
-                return false;
-            }
+            if (!ppImagePhotom(config, view)) ESCAPE ("error running photometry.");
         }
 
@@ -123 +96 @@
                 continue;
             }
-
-            if (!pmFPAfileIOChecks(config, view, PM_FPA_AFTER)) {
-                psFree(view);
-                return false;
-            }
+            if (!pmFPAfileIOChecks(config, view, PM_FPA_AFTER)) ESCAPE ("save failure for Cell");
         }
 
         // Close chip
-        if (!pmFPAfileIOChecks(config, view, PM_FPA_AFTER)) {
-            psFree(view);
-            return false;
-        }
+        if (!pmFPAfileIOChecks(config, view, PM_FPA_AFTER)) ESCAPE ("save failure for Chip");
     }
 
@@ -140 +106 @@
     // it would require us to NOT free PPIMAGE.CHIP until here
     // ppImageMosaicFPA (config, "PPIMAGE.OUTPUT.FPA", "PPIMAGE.CHIP");
-    ppImageMosaicFPA(config, options, "PPIMAGE.OUTPUT.FPA1", "PPIMAGE.BIN1");
-    ppImageMosaicFPA(config, options, "PPIMAGE.OUTPUT.FPA2", "PPIMAGE.BIN2");
+    if (!ppImageMosaicFPA(config, options, "PPIMAGE.OUTPUT.FPA1", "PPIMAGE.BIN1")) ESCAPE ("failure in FPA Mosaic (level 1)");
+    if (!ppImageMosaicFPA(config, options, "PPIMAGE.OUTPUT.FPA2", "PPIMAGE.BIN2")) ESCAPE ("failure in FPA Mosaic (level 2)");
 
     // we perform astrometry on all chips after sources have been detected
     // this also performs the psastro file IO
     if (options->doAstromChip || options->doAstromMosaic) {
-        if (!ppImageAstrom(config)) {
-            psError(PS_ERR_UNKNOWN, false, "error running astrometry.\n");
-            psFree(view);
-            return false;
-        }
+        if (!ppImageAstrom(config)) ESCAPE ("error running astrometry.");
     }
 
@@ -158 +120 @@
 
     // Write out summary statistics
-    if (!ppImageMetadataStats (config, options)) {
-        psError(PS_ERR_UNKNOWN, false, "Unable to write statistics file.\n");
-        psFree (view);
-        return false;
-    }
+    if (!ppImageMetadataStats (config, options)) ESCAPE ("Unable to write statistics file.");
 
     // Write out summary statistics
-    if (!ppImageStatsOutput (config, options)) {
-        psError(PS_ERR_UNKNOWN, false, "Unable to write statistics file.\n");
-        psFree (view);
-        return false;
-    }
+    if (!ppImageStatsOutput (config, options)) ESCAPE ("Unable to write statistics file.");
 
     // Output and Close FPA
-    if (!pmFPAfileIOChecks(config, view, PM_FPA_AFTER)) {
-        psFree(view);
-        return false;
-    }
+    if (!pmFPAfileIOChecks(config, view, PM_FPA_AFTER)) ESCAPE ("save failure for FPA");
 
     psFree(view);