Changeset 15087 for trunk/psModules/src/camera/pmFPAConstruct.c

Timestamp:

Sep 28, 2007, 2:06:47 PM (19 years ago)

Author:

Paul Price

Message:

During the recent reorganisation here, I didn't realise that there is
a function that calls addSource() that wants NOT to install the HDUs,
etc (it only wants to find the appropriate chip or cell). Pushed the
responsibility for this into the addSource_CHIP_etc functions.

File:

• trunk/psModules/src/camera/pmFPAConstruct.c (modified) (8 diffs)

trunk/psModules/src/camera/pmFPAConstruct.c

@@ -701 +701 @@
                                 pmChip *chip, // Known chip to which to add, or NULL
                                 const psMetadata *format, // The camera format
-                                pmHDU *phdu // The Primary HDU
+                                pmHDU *phdu, // The Primary HDU
+                                bool install // Install the HDUs?
                                 )
 {
@@ -746 +747 @@
     }
 
+    if (!install) {
+        // Everything below is about installing the HDUs
+        psFree(chipType);
+        return true;
+    }
+
     if (!addHDUtoChip(chip, phdu)) {
         psError(PS_ERR_UNKNOWN, false, "Unable to add HDU to chip\n");
@@ -803 +810 @@
                                 pmChip *chip, // Known chip to which to add, or NULL
                                 const psMetadata *format, // The camera format
-                                pmHDU *phdu // Primary HDU
+                                pmHDU *phdu, // Primary HDU
+                                bool install // Install the HDUs?
                                 )
 {
@@ -845 +853 @@
     }
 
+    if (!install) {
+        // Everything below is about installing the HDU
+        psFree(chipType);
+        return true;
+    }
+
     if (!addHDUtoChip(chip, phdu)) {
         psError(PS_ERR_UNKNOWN, false, "Unable to add HDU to chip\n");
@@ -879 +893 @@
                                 pmCell *cell, // Known cell to which to add, or NULL
                                 const psMetadata *format, // The camera format
-                                pmHDU *phdu // The Primary HDU
+                                pmHDU *phdu, // The Primary HDU
+                                bool install // Install the HDUs?
                                 )
 {
@@ -1029 +1044 @@
         psFree(cellNames);
         psFree(cellTypes);
+    }
+
+    if (!install) {
+        // Everything below is about installing the HDU
+        psFree(chipNames);
+        psFree(cellNames);
+        psFree(cellTypes);
+        return true;
     }
 
@@ -1201 +1224 @@
           switch (extLevel) {
             case PM_FPA_LEVEL_CELL:
-              if (install) {
-                  phdu->blankPHU = true;
-                  if (!addSource_CHIP_CELL(view, fpa, chip, format, phdu)) {
-                      psError(PS_ERR_UNKNOWN, false, "Unable to add source.");
-                      psFree(phdu);
-                      psFree(view);
-                      return NULL;
-                  }
+              phdu->blankPHU = true;
+              if (!addSource_CHIP_CELL(view, fpa, chip, format, phdu, install)) {
+                  psError(PS_ERR_UNKNOWN, false, "Unable to add source.");
+                  psFree(phdu);
+                  psFree(view);
+                  return NULL;
               }
               psFree(phdu);
               return view;
             case PM_FPA_LEVEL_NONE:
-              if (install) {
-                  phdu->blankPHU = false;
-                  if (!addSource_CHIP_NONE(view, fpa, chip, format, phdu)) {
-                      psError(PS_ERR_UNKNOWN, false, "Unable to add source.");
-                      psFree(phdu);
-                      psFree(view);
-                      return NULL;
-                  }
+              phdu->blankPHU = false;
+              if (!addSource_CHIP_NONE(view, fpa, chip, format, phdu, install)) {
+                  psError(PS_ERR_UNKNOWN, false, "Unable to add source.");
+                  psFree(phdu);
+                  psFree(view);
+                  return NULL;
               }
               psFree(phdu);
@@ -1243 +1262 @@
               cell = chip->cells->data[phuView->cell];
           }
-          if (install) {
-              phdu->blankPHU = false;
-              if (!addSource_CELL_NONE(view, fpa, cell, format, phdu)) {
-                  psError(PS_ERR_UNKNOWN, false, "Unable to add source.");
-                  psFree(phdu);
-                  psFree(view);
-                  return NULL;
-              }
+          phdu->blankPHU = false;
+          if (!addSource_CELL_NONE(view, fpa, cell, format, phdu, install)) {
+              psError(PS_ERR_UNKNOWN, false, "Unable to add source.");
+              psFree(phdu);
+              psFree(view);
+              return NULL;
           }
           psFree(phdu);