Changeset 13425 for trunk/psLib/src/math/psEllipse.c

Timestamp:

May 18, 2007, 4:06:09 AM (19 years ago)

Author:

rhl

Message:

Make psEllipsePolToAxes return psErrorCode

File:

• trunk/psLib/src/math/psEllipse.c (modified) (2 diffs)

trunk/psLib/src/math/psEllipse.c

@@ -46 +46 @@
 
 // ellipse rotation (major, minor, theta) -> (x2, y2, xy)
-psEllipseAxes psEllipsePolToAxes(psEllipsePol pol, float minMinorAxis)
+psErrorCode psEllipsePolToAxes(const psEllipsePol pol,
+                               const float minMinorAxis,
+                               psEllipseAxes *axes)
 {
-    psEllipseAxes axes;
+    axes->theta = +0.5 * atan2 (pol.e2, pol.e1); // theta in radians
 
-    axes.theta = +0.5 * atan2 (pol.e2, pol.e1); // theta in radians
-
-    double cs = cos(2*axes.theta);
-    double sn = sin(2*axes.theta);
+    double cs = cos(2*axes->theta);
+    double sn = sin(2*axes->theta);
     double ds = 0;
 
@@ -64 +64 @@
     float LIMIT = PS_SQR(minMinorAxis);
     if (2.0*(pol.e0 - ds) < LIMIT) {
-        axes.major = sqrt(pol.e0 - LIMIT);
-        axes.minor = sqrt(LIMIT);
+        axes->major = sqrt(pol.e0 - LIMIT);
+        axes->minor = sqrt(LIMIT);
     } else {
-        axes.major = sqrt(0.5*(pol.e0 + ds));
-        axes.minor = sqrt(0.5*(pol.e0 - ds));
+        axes->major = sqrt(0.5*(pol.e0 + ds));
+        axes->minor = sqrt(0.5*(pol.e0 - ds));
     }
 
-    assert (isfinite(axes.major));
-    assert (isfinite(axes.minor));
-    assert (isfinite(axes.theta));
+    if (!isfinite(axes->major) || !isfinite(axes->minor) || !isfinite(axes->theta)) {
+        return psError(PS_ERR_BAD_PARAMETER_VALUE, true, "Shape of object is NaN");
+    }
 
-    return axes;
+    return PS_ERR_NONE;
 }