Changeset 10903 for branches/jch-memory/psLib/src/sys/psMemory.c

Timestamp:

Jan 4, 2007, 12:34:06 PM (19 years ago)

Author:

jhoblitt

Message:

add HANDLE_BAD_BLOCK macro
replace all use of PS_MEM_ABORT_CORRUPT macro with HANDLE_BAD_BLOCK
remove PS_MEM_ABORT_CORRUPT macro
change badMemBlock() to accept an output parameter

File:

• branches/jch-memory/psLib/src/sys/psMemory.c (modified) (17 diffs)

branches/jch-memory/psLib/src/sys/psMemory.c

@@ -9 +9 @@
 *  @author Joshua Hoblitt, University of Hawaii
 *
-*  @version $Revision: 1.88.2.12 $ $Name: not supported by cvs2svn $
-*  @date $Date: 2007-01-04 21:55:39 $
+*  @version $Revision: 1.88.2.13 $ $Name: not supported by cvs2svn $
+*  @date $Date: 2007-01-04 22:34:06 $
 *
 *  Copyright 2004-2005 Maui High Performance Computing Center, University of Hawaii
@@ -72 +72 @@
 fprintf(stderr, "\n");
 
-#define PS_MEM_ABORT_CORRUPT(ptr) \
-PS_MEM_ABORT(file, "Memory corruption detected in block %lu, allocated at %s (%s:%d) by thread id %lu", \
-             (unsigned long)ptr->id, \
-             ptr->func, \
-             ptr->file, \
-             ptr->lineno,\
-             ptr->tid);
-
-static bool badMemBlock(const psMemBlock *memBlock);
+#define HANDLE_BAD_BLOCK(memBlock) \
+if (badMemBlock(stderr, memBlock)) { \
+    psMemBlockPrint(stderr, memBlock); \
+    PS_MEM_ABORT(__func__, "Unsafe to Continue"); \
+}
+
+static bool badMemBlock(FILE *output, const psMemBlock *memBlock);
 
 // pointer to the last mem block that was allocated
@@ -151 +149 @@
  * N.b. If the block wasn't allocated by psAlloc, it will appear corrupted
  */
-static bool badMemBlock(const psMemBlock *memBlock)
+static bool badMemBlock(FILE *output, const psMemBlock *memBlock)
 {
     // n.b. since this is called by psMemCheckCorruption while the memblock
@@ -160 +158 @@
     // as they make be changed out from underneath us by new memory allocation
     if (memBlock == NULL) {
-        PS_MEM_ERROR(PS_ERR_MEMORY_CORRUPTION, true,
-                     _("NULL memory block found."));
+        fprintf(output, _("NULL memory block found."));
         return true;
     }
@@ -167 +164 @@
     if (memBlock->refCounter == 0) {
         // using an unreferenced block of memory, are you?
-        PS_MEM_ERROR(PS_ERR_MEMORY_CORRUPTION, true,
-                     _("Memory block %lu was freed but still being used."),
-                     (unsigned long)memBlock->id);
+        fprintf(output, _("Memory block was freed but still being used."));
         return true;
     }
 
     if (memBlock->startblock != P_PS_MEMMAGIC || memBlock->endblock != P_PS_MEMMAGIC) {
-        PS_MEM_ERROR(PS_ERR_MEMORY_CORRUPTION, true,
-                     _("Memory block %lu is corrupted; buffer underflow detected."),
-                     (unsigned long)memBlock->id);
+        fprintf(output, _("Memory block is corrupted; buffer underflow detected."));
         return true;
     }
     if (*(psPtr *)((int8_t *) (memBlock + 1) + memBlock->userMemorySize) != P_PS_MEMMAGIC) {
-        PS_MEM_ERROR(PS_ERR_MEMORY_CORRUPTION, true,
-                     _("Memory block %lu is corrupted; buffer overflow detected."),
-                     (unsigned long)memBlock->id);
+        fprintf(output,
+                _("Memory block is corrupted; buffer overflow detected."));
         return true;
     }
@@ -197 +189 @@
 {
     static psMemId incr = 10; // "p_psMemAllocID += incr"
-    bool abort_on_error = false;
-
-    if (psMemCheckCorruption(stderr, abort_on_error) > 0) {
+
+    if (psMemCheckCorruption(stderr, false) > 0) {
         fprintf(stderr, "Detected memory corruption\n"); // somewhere to set a breakpoint
     }
@@ -324 +315 @@
 int psMemCheckCorruption(FILE *output, bool abort_on_error)
 {
-    psS32 nbad = 0;               // number of bad blocks
-
     // get exclusive access to the memBlock list to avoid it changing on us
     // while we use it.
     MUTEX_LOCK(&memBlockListMutex);
 
+    psS32 nbad = 0;               // number of bad blocks
     for (psMemBlock *memBlock = lastMemBlockAllocated; memBlock != NULL; memBlock = memBlock->nextBlock) {
-        if (badMemBlock(memBlock)) {
+        if (badMemBlock(output, memBlock)) {
             nbad++;
 
-            fprintf(output,
-                    "Memory corruption detected in memBlock %lu\n"
-                    "\tSize %zd\n"
-                    "\tPosts: %p %p %p\n"
-                    "\tAllocated at %s (%s:%d) by thread %lu\n",
-                    memBlock->id,
-                    memBlock->userMemorySize,
-                    memBlock->startblock, memBlock->endblock, (memBlock + 1 + memBlock->userMemorySize),
-                    memBlock->func, memBlock->file, memBlock->lineno, memBlock->tid);
+            psMemBlockPrint(output, memBlock);
 
             if (abort_on_error) {
@@ -461 +443 @@
     psMemBlock *memBlock = ((psMemBlock *)ptr) - 1;
 
-    if (badMemBlock(memBlock)) {
-        PS_MEM_ABORT(file, "Memory corruption detected in block %lu, allocated at %s (%s:%d) by thread id %lu",
-                     (unsigned long)memBlock->id,
-                     memBlock->func,
-                     memBlock->file,
-                     memBlock->lineno,
-                     memBlock->tid);
-    }
+    HANDLE_BAD_BLOCK(memBlock);
 
     if (size == memBlock->userMemorySize) {
@@ -483 +458 @@
         if (memBlock == NULL) {
             MUTEX_UNLOCK(&memBlockListMutex);
-            PS_MEM_ABORT(__func__, "Failed to reallocate %zd bytes at %s (%s:%d)", size, func, file, lineno);
+            fprintf(stderr, "Problem reallocating block\n");
+            psMemBlockPrint(stderr,  ((psMemBlock *)ptr) - 1);
+            PS_MEM_ABORT(__func__, "Failed to reallocate to %zd bytes at %s (%s:%d)", size, func, file, lineno);
         }
     }
@@ -586 +563 @@
     psMemBlock *memBlock = ((psMemBlock *) ptr) - 1;
 
-    if (badMemBlock(memBlock)) {
-        PS_MEM_ABORT_CORRUPT(memBlock);
-    }
+    HANDLE_BAD_BLOCK(memBlock);
 
     return memBlock->refCounter;
@@ -604 +579 @@
     psMemBlock* memBlock = ((psMemBlock *) ptr) - 1;
 
-    if (badMemBlock(memBlock)) {
-        PS_MEM_ABORT_CORRUPT(memBlock);
-    }
+    HANDLE_BAD_BLOCK(memBlock);
 
     memBlock->refCounter++;
@@ -664 +637 @@
     psMemBlock *memBlock = ((psMemBlock *) ptr) - 1;
 
-    if (badMemBlock(memBlock)) {
-        PS_MEM_ABORT_CORRUPT(memBlock);
-        return NULL;
-    }
+    HANDLE_BAD_BLOCK(memBlock);
 
     if (memBlock->refCounter < 1) {
@@ -732 +702 @@
     psMemBlock* memBlock = ((psMemBlock *)ptr) - 1;
 
-    if (badMemBlock(memBlock)) {
-        PS_MEM_ABORT_CORRUPT(memBlock);
-    }
+    HANDLE_BAD_BLOCK(memBlock);
 
     memBlock->freeFunc = freeFunc;
@@ -747 +715 @@
     psMemBlock* memBlock = ((psMemBlock *)ptr) - 1;
 
-    if (badMemBlock(memBlock)) {
-        PS_MEM_ABORT_CORRUPT(memBlock);
-    }
+    HANDLE_BAD_BLOCK(memBlock);
 
     return memBlock->freeFunc;
@@ -1025 +991 @@
     psMemBlock* memBlock = ((psMemBlock *) ptr) - 1;
 
-    if (badMemBlock(memBlock)) {
-        PS_MEM_ABORT_CORRUPT(memBlock);
-    }
+    HANDLE_BAD_BLOCK(memBlock);
 
     return memBlock->persistent;
@@ -1041 +1005 @@
     psMemBlock* memBlock = ((psMemBlock *) ptr) - 1;
 
-    if (badMemBlock(memBlock)) {
-        PS_MEM_ABORT_CORRUPT(memBlock);
-    }
+    HANDLE_BAD_BLOCK(memBlock);
 
     memBlock->persistent = value;
@@ -1110 +1072 @@
                    "\tPrevious Block: %p Next Block: %p\n"
                    "\tFree function: %p\n"
-                   "\tSize: %zd Reference count: %lu\n Persistent: %s\n"
+                   "\tSize: %zd Reference count: %lu Persistent: %s\n"
                    "\tPosts: %p %p %p\n"
-                   "\tAllocated at %s (%s:%d) by thread %lu\n",
+                   "\tAllocated in %s at (%s:%d)\n"
+                   "\t\tby Thread ID %lu\n",
                    memBlock->id,
                    memBlock->previousBlock, memBlock->nextBlock,