| 13 | | * I've updated the PSF I/O function save and load both the aperture correction model and the growth curve. I've also adjusted the |
| 14 | | photometry code to apply both corrections as appropriate to the psf-related mags and fluxes. Michael: you already tried the update |
| 15 | | with the aperture correction; the offset for extended sources was due to a test that did not apply it for extended sources. But, the growth |
| 16 | | curve needs to be applied consistently to both output of the straight and the forced photometry, so I needed to add that to the PSF model. This should address the offset you were seeing. the only remaining discrepancies I saw were due to the fact that psphot-straight subtracts an extended model for objects if it has one, but the cmf file does not store that model information; psphotForced is thus forced to subtract psf models for everyone. This can eventually be addressed, but it requires saving a lot more info. let me know if this is a high priority for you. |
| 17 | | * I've updated the curve of growth analysis to use the bright stars (used for the psf model); I had been cheating by using the psf model |
| 18 | | itself to judge the growth correction. some of my tests show that this was resulting in an error of about 1% for the reference aperture |
| 19 | | normally used in the analysis (25 pixels) |
| 20 | | * I have NOT changed the config files, but I have concluded that we need to move from 25 pixels for the reference aperture to something larger -- probably 35 pixels for the single image analysis. This conclusion is driven by trends I see in the zero points in the MD fields that correlated with the FWHM, but corroborated by the fact that the curve of growth still has ~1-1.5% more to go at 25 pixels, |
| 21 | | depending on the seeing. I would like to run a set of tests to confirm that bumping up the reference aperture fixes the apparent zero |
| 22 | | point trend. |
| 23 | | * the aperture magnitudes are measured in an interpolated image shifted to be centered in the circular mask; I found an error in the |
| 24 | | interpolation used for this shift. i changed the interpolation method to bilinear, which did not have the error (note that only this |
| 25 | | aperture interpolation uses that particular interpolation mode, so there are no other implied errors). The error is small for relatively |
| 26 | | large apertures, but for the smallest apertures used in the curve-of-growth analysis, it introduced some noise. I don't think anyone will notice the impact of this particular fix... |
| | 13 | * I've updated the PSF I/O function save and load both the aperture correction model and the growth curve. I've also adjusted the photometry code to apply both corrections as appropriate to the psf-related mags and fluxes. The growth curve needs to be applied consistently to both output of the straight and the forced photometry, so I needed to add that to the PSF model. |
| | 14 | * I've updated the curve of growth analysis to use the bright stars (used for the psf model); I had been cheating by using the psf model itself to judge the growth correction. some of my tests show that this was resulting in an error of about 1% for the reference aperture normally used in the analysis (25 pixels) |
| | 15 | * I have NOT changed the config files, but I have concluded that we need to move from 25 pixels for the reference aperture to something larger -- probably 35 pixels for the single image analysis. This conclusion is driven by trends I see in the zero points in the MD fields that correlated with the FWHM, but corroborated by the fact that the curve of growth still has ~1-1.5% more to go at 25 pixels, depending on the seeing. I need to run a set of tests to confirm that bumping up the reference aperture fixes the apparent zero point trend. |
| | 16 | * the aperture magnitudes are measured in an interpolated image shifted to be centered in the circular mask; I found an error in the interpolation used for this shift. i changed the interpolation method to bilinear, which did not have the error (note that only this aperture interpolation uses that particular interpolation mode, so there are no other implied errors). The error is small for relatively large apertures, but for the smallest apertures used in the curve-of-growth analysis, it introduced some noise. I don't think anyone will notice the impact of this particular fix... |