id	summary	reporter	owner	description	type	status	priority	milestone	component	version	severity	resolution	keywords	cc
575	pmSubtractBias definition wrong	Paul Price	gusciora@…	"I got the definition for pmSubtractBias wrong on a couple of points:

* The overscans are to be derived by the function using CELL.BIASSEC (a linked
list of psRegions, accessed from the parent of the readout), not from the ""bias""
parameter passed to the function (which is supposed to be the full-frame bias
image).

* The full-frame (bias and dark) subtractions should only be performed on the
region of the image specified by CELL.TRIMSEC (we don't want to subtract the
bias' overscan from the input's overscan, etc).  This is simply done by:
	psRegion *trimRegion = psMetadataLookupPtr(NULL, in->parent->concepts,
""CELL.TRIMSEC"");
	psImage *trimmed = psImageSubset(in->image, *trimRegion);
Actions on ""trimmed"" will then manifest in the readout.


I've corrected the SDRS, but wanted to let you know of these somewhat subtle fixes."	defect	closed	high		detrend	0.8.0	normal	fixed