Changeset 9388

Timestamp:

Oct 6, 2006, 5:55:24 PM (20 years ago)

Author:

magnier

Message:

do not free the supplied output on error

File:

• trunk/psLib/src/types/psMetadata.c (modified) (3 diffs)

trunk/psLib/src/types/psMetadata.c

@@ -12 +12 @@
  *  @author Ross Harman, MHPCC
  *
- *  @version $Revision: 1.135 $ $Name: not supported by cvs2svn $
- *  @date $Date: 2006-09-26 02:55:34 $
+ *  @version $Revision: 1.136 $ $Name: not supported by cvs2svn $
+ *  @date $Date: 2006-10-07 03:55:24 $
  *
  *  Copyright 2004-2005 Maui High Performance Computing Center, University of Hawaii
@@ -418 +418 @@
                            const psMetadata *in)
 {
-    //    PS_ASSERT_PTR_NON_NULL(in,NULL);
+    // in == NULL is a valid input, return 'out' as is
     if (in == NULL) {
-        if (out != NULL) {
-            psFree(out);
-            out = NULL;
-        }
-        return out;
-    }
+        psError(PS_ERR_BAD_PARAMETER_NULL, true, "psMetadataCopy: 'in' cannot be NULL");
+        return NULL;
+    }
+
     //    PS_ASSERT_PTR_NON_NULL(in->list,NULL);
     if (in->list == NULL) {
-        if (out != NULL) {
-            psFree(out);
-            out = NULL;
-        }
-        return out;
+        psError(PS_ERR_BAD_PARAMETER_NULL, true, "psMetadataCopy: 'in' has NULL list");
+        return NULL;
     }
 
@@ -457 +452 @@
             psFree(newItem);
             psFree(iter);
-            psFree(out);
-            out = NULL;
-            return out;
+            return NULL;
         }
         psFree(newItem);                // Drop reference
     }
     psFree(iter);
-
     return out;
 }