Changeset 9268

Timestamp:

Oct 4, 2006, 2:56:48 PM (20 years ago)

Author:

Paul Price

Message:

Passing command as an array to avoid problems with whitespace.

File:

• trunk/ippScripts/scripts/phase0_exp.pl (modified) (6 diffs)

trunk/ippScripts/scripts/phase0_exp.pl

@@ -119 +119 @@
 # Output results to the database
 unless ($no_update) {
-    my $command = "$p0tool -updateexp -exp_tag $exptag"; # Command to execute to update exposure parameters
+    my @command;
+    push @command, $p0tool, '-updateexp', '-exp_tag', $exptag; # Command to execute to update exposure parameters
     
     # Add the values of interest
     foreach my $constant (@{CONSTANTS()}) {
-        $command .= " -" . $constant . " " . $values{$constant};
+        push @command, ( '-' . $constant ), $values{$constant};
     }
     foreach my $variable (@{VARIABLES()}) {
@@ -129 +130 @@
         my $stats = Statistics::Descriptive::Sparse->new; # Statistics calculator
         $stats->add_data(@$array);
-        $command .= " -" . $variable . " " . $stats->mean();
+        push @command, ( '-' . $variable ), $stats->mean();
     }
 
@@ -136 +137 @@
         my $stats = Statistics::Descriptive::Sparse->new; # Statistics calculator
         $stats->add_data(@backgrounds);
-        $command .= " -" . PHASE0_BG() . " " . $stats->mean();
+        push @command, ( '-' . PHASE0_BG() ), $stats->mean(), ( '-' . PHASE0_BG_STDEV() );
         if (scalar @backgrounds == 1) {
-            $command .= ' -' . PHASE0_BG_STDEV() . " 0.0";
+            push @command, 1;
         } else {
-            $command .= " -" . PHASE0_BG_STDEV() . " " . $stats->standard_deviation();
+            push @command, $stats->standard_deviation();
         }
     }
@@ -146 +147 @@
         my $stats = Statistics::Descriptive::Sparse->new; # Statistics calculator
         $stats->add_data(@stdevs);
-        $command .= " -" . PHASE0_BG_MEAN_STDEV() . " " . $stats->mean();
+        push @command, ( '-' . PHASE0_BG_MEAN_STDEV() ), $stats->mean();
     }
     
@@ -152 +153 @@
     foreach my $detrendType (@{DETRENDS()}) {
         if (lc($values{TYPE()}) eq lc($detrendType)) {
-            $command .= " " . DETREND_FLAG;
+            push @command, DETREND_FLAG;
             last;
         }
@@ -158 +159 @@
  
     my ( $success, $error_code, $full_buf, $stdout_buf, $stderr_buf ) =
-        run(command => $command, verbose => 1);
+        run(command => \@command, verbose => 1);
     die "Unable to run phase0 update for $exptag: $error_code\n" if not $success;
 }