Changeset 9239

Timestamp:

Oct 4, 2006, 1:06:15 PM (20 years ago)

Author:

jhoblitt

Message:

improve database error handling

File:

• trunk/ippTools/src/chiptool.c (modified) (2 diffs)

trunk/ippTools/src/chiptool.c

@@ -246 +246 @@
     psArray *output = p_psDBFetchResult(config->dbh);
     if (!output) {
+        psError(PS_ERR_UNKNOWN, false, "database error");
+        return false;
+    }
+    if (!psArrayLength(output)) {
         // XXX check psError here
-        psError(PS_ERR_UNKNOWN, false, "no pending rawDetrendExp rows found");
+        psError(PS_ERR_UNKNOWN, false, "no p2PendingImfile rows found");
+        psFree(output);
         return false;
     }
@@ -375 +380 @@
     psArray *output = p_psDBFetchResult(config->dbh);
     if (!output) {
-        // XXX check psError here and decide if we need to rollback or commit
+        psError(PS_ERR_UNKNOWN, false, "database error");
+        return false;
+    }
+    if (!psArrayLength(output)) {
+        // XXX check psError here
         psError(PS_ERR_UNKNOWN, false, "no p2PendingExp rows found");
-        // XXX temporarily returning true here as typically this wouldn't be a
-        // fatal error.  false should be returned once psError() is fixed
-        //return false;
+        psFree(output);
         return true;
     }