Changeset 8461

Timestamp:

Aug 21, 2006, 4:41:22 PM (20 years ago)

Author:

jhoblitt

Message:

don't compare varchar fields with LIKE unless "LIKE" is in the metadataItem's comment

File:

• trunk/psLib/src/db/psDB.c (modified) (2 diffs)

trunk/psLib/src/db/psDB.c

@@ -12 +12 @@
  *  @author Joshua Hoblitt
  *
- *  @version $Revision: 1.83 $ $Name: not supported by cvs2svn $
- *  @date $Date: 2006-08-15 03:23:40 $
+ *  @version $Revision: 1.84 $ $Name: not supported by cvs2svn $
+ *  @date $Date: 2006-08-22 02:41:22 $
  *
  *  Copyright (C) 2005-2006  Joshua Hoblitt, University of Hawaii
@@ -1649 +1649 @@
             psStringAppend(&query, "%s IS NULL", item->name);
         } else {
-            // XXX ASC NOTE: we should have a better match for
-            // char & varchar columns than this.  LIKE is OK for
-            // very large TEXT columns that really shouldn't be
-            // used in a where clause...
-            psStringAppend(&query, "%s LIKE '%s'", item->name, item->data.V);
+            if (item->comment && strstr(item->comment, "LIKE")) {
+                // XXX ASC NOTE: we should have a better match for
+                // char & varchar columns than this.  LIKE is OK for
+                // very large TEXT columns that really shouldn't be
+                // used in a where clause...
+                psStringAppend(&query, "%s LIKE '%s'", item->name, item->data.V);
+            } else {
+                psStringAppend(&query, "%s = '%s'", item->name, item->data.V);
+            }
         }
     } else {