Changeset 8051

Timestamp:

Aug 1, 2006, 4:47:01 PM (20 years ago)

Author:

jhoblitt

Message:

make -done partially transactional

File:

• trunk/ippTools/src/chiptool.c (modified) (3 diffs)

trunk/ippTools/src/chiptool.c

@@ -173 +173 @@
     }
 
+    // start a transaction so we don't end up with an incremented iteration
+    // count but no detInputExps
+    if (!psDBTransaction(config->dbh)) {
+        psError(PS_ERR_UNKNOWN, false, "database error");
+        psFree(valid_exp_ids);
+        return false;
+    }
+
     // insert into done
     for (long i = 0; i < psArrayLength(pendingImfiles); i++) {
         p2DoneImfileRow *imfile = p2pendingToDoneImfile(config, pendingImfiles->data[0]);
         if (!imfile) {
+            // rollback
+            if (!psDBRollback(config->dbh)) {
+                psError(PS_ERR_UNKNOWN, false, "database error");
+            }
             psError(PS_ERR_UNKNOWN, false, "failed to convert p2PendingImfile to p2DoneImfile");
             psFree(pendingImfiles);
@@ -182 +194 @@
         }
         if (!p2DoneImfileInsertObject(config->dbh, imfile)) {
+            // rollback
+            if (!psDBRollback(config->dbh)) {
+                psError(PS_ERR_UNKNOWN, false, "database error");
+            }
             psError(PS_ERR_UNKNOWN, false, "dbh access failed");
             psFree(imfile);
@@ -193 +209 @@
     if (p2PendingImfileDeleteRowObjects(config->dbh, pendingImfiles, MAX_ROWS) < 0) {
         // there must be atleast 1 Imfile to get this far
+        // rollback
+        if (!psDBRollback(config->dbh)) {
+            psError(PS_ERR_UNKNOWN, false, "database error");
+        }
         psError(PS_ERR_UNKNOWN, false, "dbh access failed");
         return false;
     }
+
+    // point of no return for p2PendingImfile -> p2DoneImfile 
+    if (!psDBCommit(config->dbh)) {
+        psError(PS_ERR_UNKNOWN, false, "database error");
+        return false;
+    }
+
+    // XXX make exposure state transition transactional
 
     // look for pending exposures