Changeset 6740

Timestamp:

Mar 30, 2006, 1:46:51 PM (20 years ago)

Author:

Paul Price

Message:

Squashing memory leak.

File:

• branches/rel10_ifa/psModules/src/astrom/pmFPAConstruct.c (modified) (3 diffs)

branches/rel10_ifa/psModules/src/astrom/pmFPAConstruct.c

@@ -169 +169 @@
     }
     psMetadataAddStr(fpa->concepts, PS_LIST_HEAD, "FPA.NAME", PS_META_REPLACE, "Name of FPA", newFPAname);
+    psFree(newFPAname);                 // Drop reference
 
     // Where does the PHU go?
@@ -372 +373 @@
 
                 // Put in the extension
-                if (chip->hdu && chip->hdu != hdu) {
-                    psLogMsg(__func__, PS_LOG_WARN, "Overwriting HDU in chip %s\n", chipName);
-                    psFree(chip->hdu);  // Make way!
-                }
-                chip->hdu = psMemIncrRefCounter(hdu);
+                if (chip->hdu) {
+                    if (chip->hdu != hdu) {
+                        psLogMsg(__func__, PS_LOG_WARN, "Overwriting HDU in chip %s\n", chipName);
+                        psFree(chip->hdu);  // Make way!
+                    }
+                } else {
+                    chip->hdu = psMemIncrRefCounter(hdu);
+                }
 
                 // Put in the cell data
@@ -434 +438 @@
                 // Put in the extension
                 if (cell->hdu) {
-                    psLogMsg(__func__, PS_LOG_WARN, "Overwriting HDU in chip %s, cell %s\n", chipName,
-                             cellName);
-                    psFree(cell->hdu);
-                }
-                cell->hdu = psMemIncrRefCounter(hdu);
+                    if (cell->hdu != hdu) {
+                        psLogMsg(__func__, PS_LOG_WARN, "Overwriting HDU in chip %s, cell %s\n", chipName,
+                                 cellName);
+                        psFree(cell->hdu);
+                    }
+                } else {
+                    cell->hdu = psMemIncrRefCounter(hdu);
+                }
 
                 // Put in the cell data