Changeset 6625

Timestamp:

Mar 16, 2006, 5:40:46 PM (20 years ago)

Author:

jhoblitt

Message:

make fileid, bytes, md5sum, & type params to ->new() optional
remove filename param writable test from ->request()

File:

• trunk/DataStore/lib/DataStore/File.pm (modified) (7 diffs)

trunk/DataStore/lib/DataStore/File.pm

@@ -1 +1 @@
 # Copyright (C) 2006  Joshua Hoblitt
 #
-# $Id: File.pm,v 1.9 2006-03-17 01:11:23 jhoblitt Exp $
+# $Id: File.pm,v 1.10 2006-03-17 03:40:46 jhoblitt Exp $
 
 package DataStore::File;
@@ -18 +18 @@
 use Digest::MD5::File qw( file_md5_hex );
 use File::stat;
-use POSIX ();
 use Params::Validate qw( validate SCALAR );
 
@@ -128 +127 @@
                 type        => SCALAR,
                 regex       => $STD_FIELD,
+                optional    => 1,
             },
             bytes   => {
                 type        => SCALAR,
                 regex       => $BYTE_FIELD,
+                optional    => 1,
             },
             md5sum  => {
                 type        => SCALAR,
                 regex       => $MD5_FIELD,
+                optional    => 1,
             },
             type    => {
@@ -143 +145 @@
                         sub { exists $KNOWN_FILE_TYPES{$_[0]} },
                 },
+                optional    => 1,
             },
         },
@@ -181 +184 @@
 object.
 
-XXX writing the file into memory or to a filehandle will be implimented upon
+XXX writing the file into memory or to a filehandle will be implemented upon
 request.
 
@@ -192 +195 @@
 =item * filename
 
-The filename/path to save the file to disk as.
+The filename/path to save the file to disk as.  It is the user's responsibility
+to make sure that this is a valid filename/path.
 
 =back
@@ -206 +210 @@
             filename    => {
                 type        => SCALAR,
-                regex       => qr/\S+/, # string with atleast 1 non WS char
-                callbacks   => {
-                    'write access' => sub {
-                        POSIX::access($_[0], &POSIX::W_OK);
-                    },
-                },
+                regex       => qr/\S+/, # string with at least 1 non WS char
             },
         },