Changeset 6608

Timestamp:

Mar 16, 2006, 11:57:29 AM (20 years ago)

Author:

jhoblitt

Message:

change DataStore::Record->new to create an object with all params as object data
change DataStore::Record subclasses to rely on DataStore::Record to create objects with all params as object data

Location:

trunk/DataStore/lib/DataStore

Files:

• File.pm (modified) (3 diffs)
• FileSet.pm (modified) (3 diffs)
• Product.pm (modified) (3 diffs)
• Record.pm (modified) (2 diffs)

trunk/DataStore/lib/DataStore/File.pm

@@ -1 +1 @@
 # Copyright (C) 2006  Joshua Hoblitt
 #
-# $Id: File.pm,v 1.7 2006-03-16 21:44:58 jhoblitt Exp $
+# $Id: File.pm,v 1.8 2006-03-16 21:57:29 jhoblitt Exp $
 
 package DataStore::File;
@@ -112 +112 @@
     my $class = shift;
 
-    # validates uri, ignores other params
+    # validates uri, doesn't check other params
     my $self = $class->SUPER::new(@_);
 
-    my %p = validate(@_,
+    validate(@_,
         {
             uri             => {
@@ -130 +130 @@
         },
     );
-
-    $self->{fileid} = $p{fileid};
-    $self->{bytes}  = $p{bytes};
-    $self->{md5sum} = $p{md5sum};
-    $self->{type}   = $p{type};
 
     return $self;

trunk/DataStore/lib/DataStore/FileSet.pm

@@ -1 +1 @@
 # Copyright (C) 2006  Joshua Hoblitt
 #
-# $Id: FileSet.pm,v 1.5 2006-03-16 21:44:58 jhoblitt Exp $
+# $Id: FileSet.pm,v 1.6 2006-03-16 21:57:29 jhoblitt Exp $
 
 package DataStore::FileSet;
@@ -104 +104 @@
     my $class = shift;
 
-    # validates uri, ignores other params
+    # validates uri, doesn't check other params
     my $self = $class->SUPER::new(@_);
 
-    my %p = validate(@_,
+    validate(@_,
         {
             uri             => {
@@ -121 +121 @@
         },
     );
-
-    $self->{fileset}    = $p{fileset};
-    $self->{datetime}   = $p{datetime};
-    $self->{type}       = $p{type};
 
     return $self;

trunk/DataStore/lib/DataStore/Product.pm

@@ -1 +1 @@
 # Copyright (C) 2006  Joshua Hoblitt
 #
-# $Id: Product.pm,v 1.5 2006-03-16 21:44:58 jhoblitt Exp $
+# $Id: Product.pm,v 1.6 2006-03-16 21:57:29 jhoblitt Exp $
 
 package DataStore::Product;
@@ -95 +95 @@
     my $class = shift;
 
-    # validates uri, ignores other params
+    # validates uri, doesn't check other params
     my $self = $class->SUPER::new(@_);
 
-    my %p = validate(@_,
+    validate(@_,
         {
             uri             => {
@@ -116 +116 @@
         },
     );
-
-    $self->{last_fileset} = $p{last_fileset};
 
     return $self;

trunk/DataStore/lib/DataStore/Record.pm

@@ -1 +1 @@
 # Copyright (C) 2006  Joshua Hoblitt
 #
-# $Id: Record.pm,v 1.5 2006-03-16 21:44:58 jhoblitt Exp $
+# $Id: Record.pm,v 1.6 2006-03-16 21:57:29 jhoblitt Exp $
 
 package DataStore::Record;
@@ -69 +69 @@
     );
 
-    my $self = bless { uri => $p{uri} }, ref $class || $class;
+    my $self = bless \%p, ref $class || $class;
 
     return $self;