Changeset 6431

Timestamp:

Feb 15, 2006, 10:01:04 PM (20 years ago)

Author:

magnier

Message:

added correct constraint handling

File:

• branches/rel10_ifa/psLib/src/math/psMinimizeLMM.c (modified) (7 diffs)

branches/rel10_ifa/psLib/src/math/psMinimizeLMM.c

@@ -10 +10 @@
  *  @author EAM, IfA
  *
- *  @version $Revision: 1.5 $ $Name: not supported by cvs2svn $
- *  @date $Date: 2006-02-07 23:14:21 $
+ *  @version $Revision: 1.5.6.1 $ $Name: not supported by cvs2svn $
+ *  @date $Date: 2006-02-16 08:01:04 $
  *
  *  Copyright 2004-2005 Maui High Performance Computing Center, University of Hawaii
@@ -301 +301 @@
 NOTES: EAM: this is my re-implementation of MinLM
  
-XXX: Must implement code to handle the constrain->min, ->max, ->delta members.
+XXX: EAM : constraints added 2006.02.15
  
 XXX: Put the ASSERTS in.
@@ -328 +328 @@
     PS_ASSERT_VECTOR_TYPE(params, PS_TYPE_F32, false);
     psVector *paramMask = NULL;
+    psVector *paramDelta = NULL;
+    psVector *paramMin = NULL;
+    psVector *paramMax = NULL;
     if (constrain != NULL) {
+        // XXX EAM : fill out the asserts
+        paramDelta = constrain->paramDelta;
+        paramMin = constrain->paramMin;
+        paramMax = constrain->paramMax;
         paramMask = constrain->paramMask;
         if (paramMask != NULL) {
             PS_ASSERT_VECTOR_TYPE(paramMask, PS_TYPE_U8, false);
             PS_ASSERT_VECTORS_SIZE_EQUAL(params, paramMask, false);
-        }
-        if (constrain->paramMin != NULL) {
-            psLogMsg(__func__, PS_LOG_WARN, "WARNING: the constrain->paramMin vector is currently ignored.\n");
-        }
-        if (constrain->paramMax != NULL) {
-            psLogMsg(__func__, PS_LOG_WARN, "WARNING: the constrain->paramMax vector is currently ignored.\n");
-        }
-        if (constrain->paramDelta != NULL) {
-            psLogMsg(__func__, PS_LOG_WARN, "WARNING: the constrain->paramDelta vector is currently ignored.\n");
         }
     }
@@ -373 +371 @@
     psF64 Chisq = 0.0;
     psF64 lambda = 0.001;
-    // XXX: Code this properly.  Don't use mustFree00.
-    psBool mustFree00 = false;
-    psVector *beta_lim = NULL;
-    psVector *param_min = NULL;
-    psVector *param_max = NULL;
-
-    // if we are provided a covar image, we expect to find these three vectors in first three rows
-    if (covar != NULL) {
-        mustFree00 = true;
-        beta_lim  = psVectorAlloc(params->n, PS_TYPE_F32);
-        param_min = psVectorAlloc(params->n, PS_TYPE_F32);
-        param_max = psVectorAlloc(params->n, PS_TYPE_F32);
-        for (int i = 0; i < params->n; i++) {
-            beta_lim->data.F32[i] = covar->data.F64[0][i];
-            param_min->data.F32[i] = covar->data.F64[1][i];
-            param_max->data.F32[i] = covar->data.F64[2][i];
-        }
-        psImageRecycle(covar, params->n, params->n, PS_TYPE_F64);
-    }
 
     // why is this needed here??? the initial guess on params is provided by the user
@@ -431 +410 @@
         // set a new guess for Alpha, Beta, Params
         p_psMinLM_GuessABP(Alpha, Beta, Params, alpha, beta, params, paramMask,
-                           beta_lim, param_min, param_max, lambda);
+                           paramDelta, paramMin, paramMax, lambda);
 
         // measure linear model prediction
@@ -488 +467 @@
     if (covar != NULL) {
         p_psMinLM_GuessABP(covar, Beta, Params, alpha, beta, params, paramMask,
-                           beta_lim, param_min, param_max, 0.0);
+                           paramDelta, paramMin, paramMax, 0.0);
     }
 
@@ -499 +478 @@
     if (yWt == NULL) {
         psFree(dy);
-    }
-    if (mustFree00 == true) {
-        psFree(beta_lim);
-        psFree(param_min);
-        psFree(param_max);
     }
     if (min->iter == min->maxIter) {