Changeset 5188 for trunk/psModules/src/imsubtract

Timestamp:

Sep 29, 2005, 11:57:31 AM (21 years ago)

Author:

gusciora

Message:

Modified psSpline fitting function calls.

File:

• trunk/psModules/src/imsubtract/pmSubtractBias.c (modified) (4 diffs)

trunk/psModules/src/imsubtract/pmSubtractBias.c

@@ -6 +6 @@
  *  @author GLG, MHPCC
  *
- *  @version $Revision: 1.1 $ $Name: not supported by cvs2svn $
- *  @date $Date: 2005-09-28 20:43:52 $
+ *  @version $Revision: 1.2 $ $Name: not supported by cvs2svn $
+ *  @date $Date: 2005-09-29 21:57:30 $
  *
  *  Copyright 2004 Maui High Performance Computing Center, University of Hawaii
@@ -236 +236 @@
         // Fit a spline to the old overscan vector.
         mySpline = (psSpline1D *) fitSpec;
+        // XXX: Does it make any sense to have a psSpline argument?
         if (mySpline == NULL) {
             mustFreeSpline = 1;
@@ -242 +243 @@
         //
         // NOTE: Since the X arg in the psVectorFitSpline1D() function is NULL,
-        // splines enpoints will be from 0.0 to overscanVector->n-1.  Must scale
+        // splines endpoints will be from 0.0 to overscanVector->n-1.  Must scale
         // properly when doing the spline eval.
         //
-        mySpline = psVectorFitSpline1D(mySpline, NULL, overscanVector, NULL);
+        //        mySpline = psVectorFitSpline1D(mySpline, NULL, overscanVector, NULL);
+        mySpline = psVectorFitSpline1D(NULL, overscanVector);
         if (mySpline == NULL) {
             psError(PS_ERR_UNKNOWN, false, "ScaleOverscanVector()(2): Could not fit a spline to the psVector.\n");
@@ -593 +595 @@
                 }
             } else if (fit == PM_FIT_SPLINE) {
+                // XXX: This makes no sense
+                // XXX: must free mySpline?
                 mySpline = (psSpline1D *) fitSpec;
-                mySpline = psVectorFitSpline1D(mySpline, NULL, overscanVector, NULL);
+                mySpline = psVectorFitSpline1D(NULL, overscanVector);
                 if (mySpline == NULL) {
                     psError(PS_ERR_UNKNOWN, false, "Could not fit a spline to overscan vector.  Returning in image.\n");