Changeset 41659

Timestamp:

Jun 8, 2021, 4:03:30 PM (5 years ago)

Author:

eugene

Message:

fix global vs local variables

File:

• trunk/psastro/src/psastroFindChipGPC.c (modified) (2 diffs)

trunk/psastro/src/psastroFindChipGPC.c

@@ -26 +26 @@
 static psImage *chipCenters = NULL;
 
-static double XminFPA = +FLT_MAX;
-static double XmaxFPA = -FLT_MAX;
-static double YminFPA = +FLT_MAX;
-static double YmaxFPA = -FLT_MAX;
-
+// XXX these should not be defined as global (only used in psastroChipBoundsGPC)
+// static double XmaxFPA = -FLT_MAX;
+// static double YmaxFPA = -FLT_MAX;
+
+// these are used in gsastroFindChipGPC to find the chip match:
+static double XminFPA   = +FLT_MAX;
+static double YminFPA   = +FLT_MAX;
 static double xInvScale = NAN;
 static double yInvScale = NAN;
@@ -41 +43 @@
     chipYmax = psVectorAlloc (fpa->chips->n, PS_TYPE_F32);
 
-    double XminFPA = +FLT_MAX;
+    // XXX these should not be declared local (override the global values)
+    // double XminFPA = +FLT_MAX;
+    // double YminFPA = +FLT_MAX;
+
     double XmaxFPA = -FLT_MAX;
-    double YminFPA = +FLT_MAX;
     double YmaxFPA = -FLT_MAX;