Changeset 41526

Timestamp:

Apr 2, 2021, 2:52:30 PM (5 years ago)

Author:

eugene

Message:

plug a leak from dropped transformations; minor comment and whitespace changes; add applyPixelNaN lookup to config->arguments

Location:

trunk/pswarp/src

Files:

• pswarpCleanup.c (modified) (1 diff)
• pswarpDefineLayout.c (modified) (1 diff)
• pswarpLoadAstrometry.c (modified) (1 diff)
• pswarpLoop.c (modified) (1 diff)
• pswarpOptions.c (modified) (3 diffs)
• pswarpTransformReadout.c (modified) (1 diff)
• pswarpTransformTile.c (modified) (1 diff)

trunk/pswarp/src/pswarpCleanup.c

@@ -86 +86 @@
         }
     }
+
     if (!pmFPAfileIOChecks (config, view, PM_FPA_AFTER)) {
         psError(psErrorCodeLast(), false, "Unable to write files.");

trunk/pswarp/src/pswarpDefineLayout.c

@@ -174 +174 @@
 
     psImageInit(readout->image, NAN);
-    psFree(readout);                // Drop reference
+    psFree(readout);                // Drop reference (saved on cell)
                 
     // copy the image concepts from the skycell 

trunk/pswarp/src/pswarpLoadAstrometry.c

@@ -150 +150 @@
             }
         }
-        targetChip->toFPA = psMemIncrRefCounter (chip->toFPA);
-        targetChip->fromFPA = psMemIncrRefCounter (chip->fromFPA);
+        if (targetChip != chip) {
+          psAssert (!targetChip->toFPA, "oops");
+          psAssert (!targetChip->fromFPA, "oops");
+          targetChip->toFPA = psMemIncrRefCounter (chip->toFPA);
+          targetChip->fromFPA = psMemIncrRefCounter (chip->fromFPA);
+        }
     }
 
     // for pswarpLocalFrame, I need transformations and HDUs on a single fpa (so set on astrom as well as target)
-    target->fpa->toTPA = psMemIncrRefCounter (astrom->fpa->toTPA);
-    target->fpa->fromTPA = psMemIncrRefCounter (astrom->fpa->fromTPA);
-    target->fpa->toSky = psMemIncrRefCounter (astrom->fpa->toSky);
+    // But: do not increment the ref counter if this is the same entry
+    if (target->fpa != astrom->fpa) {
+      psAssert (!target->fpa->toTPA, "oops");
+      psAssert (!target->fpa->fromTPA, "oops");
+      psAssert (!target->fpa->toSky, "oops");
+      target->fpa->toTPA = psMemIncrRefCounter (astrom->fpa->toTPA);
+      target->fpa->fromTPA = psMemIncrRefCounter (astrom->fpa->fromTPA);
+      target->fpa->toSky = psMemIncrRefCounter (astrom->fpa->toSky);
+    }
 
     // reset the type to the original value

trunk/pswarp/src/pswarpLoop.c

@@ -15 +15 @@
 bool pswarpLoop(pmConfig *config, psMetadata *stats)
 {
-
     // load the recipe
     bool status = false;

trunk/pswarp/src/pswarpOptions.c

@@ -70 +70 @@
     }
 
+    bool applyPixelNaN = psMetadataLookupBool(&status,recipe, "APPLY.PIXELNAN"); ///< apply NaN value to masked pixels
+    if (!status) {
+        applyPixelNaN = true;
+        psWarning("APPLY.PIXELNAN is not set in the %s recipe -- defaulting to %d.", PSWARP_RECIPE, applyPixelNaN);
+    }
+    
     // BACKGROUND.MODEL gets set in config->arguments (to false) if no input model is found
     bool doBKG = psMetadataLookupBool(&status,config->arguments, "BACKGROUND.MODEL"); ///< Generate the warped background model?
@@ -109 +115 @@
     psMetadataAddBool(recipe, PS_LIST_TAIL, "PSF", PS_META_REPLACE, "Generate a PSF Model?", PSF);
     psMetadataAddBool(recipe, PS_LIST_TAIL, "BACKGROUND.MODEL", PS_META_REPLACE, "Generate the warped background model?", doBKG);
+    psMetadataAddBool(recipe, PS_LIST_TAIL, "APPLY.PIXELNAN", PS_META_REPLACE, "apply NaN values to bad pixels?", applyPixelNaN);
     psMetadataAddS32(recipe, PS_LIST_TAIL, "BKG.XGRID", PS_META_REPLACE, "Xsize of background model", bkgXgrid);
     psMetadataAddS32(recipe, PS_LIST_TAIL, "BKG.YGRID", PS_META_REPLACE, "Ysize of background model", bkgYgrid);
@@ -120 +127 @@
     psMetadataAddBool(config->arguments, PS_LIST_TAIL, "PSF", PS_META_REPLACE, "Generate a PSF Model?", PSF);
     psMetadataAddBool(config->arguments, PS_LIST_TAIL, "BACKGROUND.MODEL", PS_META_REPLACE, "Generate the warped background model?", doBKG);
+    psMetadataAddBool(config->arguments, PS_LIST_TAIL, "APPLY.PIXELNAN", PS_META_REPLACE, "apply NaN values to bad pixels?", applyPixelNaN);
     psMetadataAddS32(config->arguments, PS_LIST_TAIL, "BKG.XGRID", PS_META_REPLACE, "Xsize of background model", bkgXgrid);
     psMetadataAddS32(config->arguments, PS_LIST_TAIL, "BKG.YGRID", PS_META_REPLACE, "Ysize of background model", bkgYgrid);

trunk/pswarp/src/pswarpTransformReadout.c

@@ -40 +40 @@
     // output mask bits
     psImageMaskType maskIn   = 0 ;
-    if(doApplyMaskNaN) {
+    if (doApplyMaskNaN) {
       maskIn   = psMetadataLookupImageMask(&mdok, recipe, "MASK.INPUT");
       psAssert(mdok, "MASK.INPUT was not defined");

trunk/pswarp/src/pswarpTransformTile.c

@@ -132 +132 @@
             double imageValue, varValue; // Value of image and variance map
             psImageMaskType maskValue = inMaskData ? inMaskData[(int)yIn][(int)xIn] : 0; // Value of mask
-            if (!psImageInterpolate(&imageValue, &varValue, &maskValue, xIn, yIn, args->interp)) {
+
+            if (!psImageInterpolate(&imageValue, &varValue, &maskValue, xIn, yIn, args->interp)) {
                 psError(psErrorCodeLast(), false, "Unable to interpolate image.");
                 return false;