Changeset 32687 for trunk

Timestamp:

Nov 17, 2011, 10:33:52 AM (14 years ago)

Author:

bills

Message:

Fix SEGV which may happen with corrupt input files

File:

• trunk/magic/remove/src/streaksio.c (modified) (2 diffs)

trunk/magic/remove/src/streaksio.c

@@ -632 +632 @@
 
     if (!isImage(in)) {
+        psLogMsg("streaksremove", PS_LOG_INFO, "%s contains no image\n", in->name);
         return;
     }
@@ -779 +780 @@
 setupImageRefs(sFile *out, sFile *recoveryOut, sFile *in, int extnum, bool exciseAll)
 {
+    if (!in->image) {
+        // Input file is likely corrupt. XXX: Shouldn't we have caught this earlier?
+        psError(PS_ERR_UNKNOWN, true, "image is null for extension %d of %s file is likely corrupt", extnum, in->name);
+        streaksExit("", PS_EXIT_UNKNOWN_ERROR);
+    }
     if (!exciseAll) {
         // set output image to be the input image