Changeset 31547

Timestamp:

May 12, 2011, 4:50:51 PM (15 years ago)

Author:

eugene

Message:

do not generate useless vtable for image table in relastro; fix typo in typetest

Location:

branches/eam_branches/ipp-20110505/Ohana/src

Files:

• libohana/test/typetest.c (modified) (1 diff)
• relastro/src/load_images.c (modified) (1 diff)

branches/eam_branches/ipp-20110505/Ohana/src/libohana/test/typetest.c

@@ -74 +74 @@
 
     big_value = 10;
-    fprintf (stderr, "this is a bit int: "OFF_T_FMT" n'est pas?\n", big_value);
+    fprintf (stderr, "this is a big int: "OFF_T_FMT" n'est pas?\n", big_value);
+
+    // we could move the % out of the FMT and allow constructions like this:
+    // # define OFF_T_FMT "jd"
+    // fprintf (stderr, "this is a big int: %06"OFF_T_FMT_ALT" n'est pas?\n", big_value);
+    // still kind of ugly...
 
     exit (status);

branches/eam_branches/ipp-20110505/Ohana/src/relastro/src/load_images.c

@@ -44 +44 @@
   MARKTIME("  select images: %f sec\n", dtime);
 
-  gfits_vtable_from_ftable (&db[0].ftable, &db[0].vtable, LineNumber, Nsubset);
+  // generate db->vtable from db->ftable based on the selection
+  // XXX does this simply duplicate the memory needlessly?  we recreate these lines
+  // in reload_images.  If we had saved the line numbers, we could avoid this
+  // vtable points *another* copy of the subset rows
+  // (the later call to 'reload_images' copies the subset elements back on top of 
+  // the rows of the vtable)
+  // gfits_vtable_from_ftable (&db[0].ftable, &db[0].vtable, LineNumber, Nsubset);
+  // MARKTIME("converted ftable to vtable: %f sec\n", dtime);
 
   initImages (subset, Nsubset);